Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI_gaththerV as an intermediate step between LS_root and LS_distributed(bk=cs_grid) #2660

Merged
merged 20 commits into from
Apr 2, 2024

Conversation

metdyn
Copy link
Contributor

@metdyn metdyn commented Mar 19, 2024

Description

Trajectory sampler: add locstream_chunk and MPI_gaththerV as an intermediate step between ls_rt and ls_distributed(bk=cs_grid) to save computational time, coauthored with @bena-nasa and @tclune.

Regrid C5760_L2 to 6-hr IODA locstream points (29 platform) takes 68.059 s (HISTORY) with 1200 cores.

A related issue is the timing for MPI_gatherV from LS_distributed (equal number of points) to LS_root using either LEVEL_BY_LEVEL or ALL_IN_ONCE:

Title:  time(history)/s  from  Extdatadriver.x
 
X_Z_M          T/s(3d gatherV)	   T/s(2d gatherV  level by level)
------------------------------------------------
c1440_L137_M1260  69.870     57.276
c1440_L137_M5040  95.762
c5760_L137_M8820  93.140     98.494
 
M=cores on discover
------------------------------------------------
Nobs=1543929

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@metdyn metdyn requested a review from a team as a code owner March 19, 2024 04:59
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

gridcomps/History/Sampler/MAPL_TrajectoryMod_smod.F90 Outdated Show resolved Hide resolved
gridcomps/History/Sampler/MAPL_TrajectoryMod_smod.F90 Outdated Show resolved Hide resolved
@metdyn
Copy link
Contributor Author

metdyn commented Mar 21, 2024

working offline for improvement

@metdyn metdyn closed this Mar 21, 2024
@metdyn metdyn reopened this Mar 25, 2024
@tclune tclune self-requested a review March 28, 2024 16:43
CHANGELOG.md Outdated Show resolved Hide resolved
@tclune tclune self-requested a review April 1, 2024 15:53
tclune
tclune previously requested changes Apr 1, 2024
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline commentns.

@metdyn
Copy link
Contributor Author

metdyn commented Apr 2, 2024

See inline commentns.

I think the comment has been resolved (code was revised.)

@metdyn metdyn dismissed tclune’s stale review April 2, 2024 19:38

The old code was revised and I cannot find the corresponding lines any more

@tclune tclune self-requested a review April 2, 2024 20:09
@tclune tclune merged commit 048e186 into develop Apr 2, 2024
29 checks passed
@tclune tclune deleted the feature/ygyu/locstream_chunk branch April 2, 2024 21:12
@mathomp4 mathomp4 mentioned this pull request Apr 3, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants