Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing c_ptr declaration for ESMF 8.6.1b04 #2776

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add missing c_ptr declaration for ESMF 8.6.1b04 #2776

merged 1 commit into from
Apr 23, 2024

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Apr 23, 2024 •
edited
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Testing of Baselibs 7.24 (see GEOS-ESM/ESMA-Baselibs#184) on MAPL showed that one test failed to build. The reason is that between ESMF 8.6.0 and 8.6.1b04, ESMF tightened things up and made sure no iso_c_binding bits were leaking through use ESMF.

This one test apparently still did that, so we add a line. That's it!

Related Issue

@mathomp4 mathomp4 added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer labels Apr 23, 2024
@mathomp4 mathomp4 self-assigned this Apr 23, 2024
@mathomp4 mathomp4 requested a review from a team as a code owner April 23, 2024 13:29
@mathomp4 mathomp4 changed the title Add missing c_ptr declaration Add missing c_ptr declaration for ESMF 8.6.1b04 Apr 23, 2024
@mathomp4 mathomp4 merged commit a37a52c into develop Apr 23, 2024
47 checks passed
@mathomp4 mathomp4 deleted the bugfix/mathomp4/fix-use-cptr branch April 23, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) Changelog Skip Skips the Changelog Enforcer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @tclune