Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3353 Feature/tclune/#3353 introduce aspect map #3354

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Fixes #3353 Feature/tclune/#3353 introduce aspect map #3354

merged 6 commits into from
Jan 22, 2025

Conversation

tclune
Copy link
Collaborator

@tclune tclune commented Jan 21, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

tclune added 5 commits January 19, 2025 12:07
@tclune
Introducing AspectMap.
99bd857 
And using somewhat customized definition of the gFTL map to allow for
circular interfaces.
@tclune
Nothing broken yet.
c62d1a5 
New stuff not integrated yet.
@tclune
Missed some changes.
9f83cc5 
"VERTICAL" --> "VERTICAL_GRID"
@tclune
Made connect_to deferred.
188abd0
@tclune
Added connect_to...() methods to Apsect.
fa9a467
@tclune tclune added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Jan 21, 2025
@tclune tclune requested a review from a team as a code owner January 21, 2025 21:54
@tclune tclune merged commit 9ebc045 into release/MAPL-v3 Jan 22, 2025
39 checks passed
@tclune tclune deleted the feature/tclune/#3353-introduce-aspect-map branch January 22, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrayano atrayano atrayano approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclune @atrayano