-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bmauer/identify vertical coord extdata2g #3434
Merged
tclune
merged 47 commits into
develop
from
feature/bmauer/identify_vertical_coord_extdata2g
Feb 19, 2025
Merged
Feature/bmauer/identify vertical coord extdata2g #3434
tclune
merged 47 commits into
develop
from
feature/bmauer/identify_vertical_coord_extdata2g
Feb 19, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tclune
reviewed
Feb 18, 2025
tclune
reviewed
Feb 18, 2025
tclune
reviewed
Feb 18, 2025
tclune
reviewed
Feb 18, 2025
tclune
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please answer the one inline question I asked before merging. And the very small suggestion edits. (capitalize params)
And ... you are now not allowed to leave NASA until your knowledge is captured in MAPL3 on this front.
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
Co-authored-by: Tom Clune <thomas.l.clune@nasa.gov>
tclune
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 Diff
The changes in this pull request have verified to be zero-diff with the target branch.
🎁 New Feature
This is a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR to get a beta version of proper vertical constituent regridding into ExtData2G. It seemed like it was time for a pause to get this in now that it is getting really big and I have a few cases working.
Basically the idea as follows.
I have redone the detection of the vertical level in the file, and identify it according to CF as either hybrid sigma, fixed pressures/heights etc, or just "simple" coordinate if it doesn't follow either of those according to the letter of CF in new code.
If it is hybrid sigma, then that means there is a surface pressure and ak/bk in the file (note that I'm not entirely satisfied with the format for the file I coded to, I tried to follow CF, but might want to change; see plan at end of issue). I add a new rule, borrowing the original items parameters to read PS like any other item, so it gets regridded, time interpolated etc.
Then after the time interpolation I check if hybrid sigma, then regrid.
This so far has limited functionality and supports regridding from a file on hybrid sigma levels as defined by the CF conventions with a time varying pressure and ak/bk in the file. It only supports constituents in either mass mixing ratios:
kg kg-1
or mass per area per second. I.E.kg m-2 s-1
. This uses the ppm code (brought a version into MAPL) from FV3 to conservatively regrid and also has corrections at the surface to ensure that mass is conserved.I can go into greater detail what is being done here if needed.
In addition, in order for this feature to be usable ExtData must import PLE. This can be accomplished using the version Kyle added to the Cap by specify this in the CAP.rc file
I have been testing this all along for 0 diff.
This is the first hopefully what will be much more frequent PR's now once this is in. The plan is as follows:
mol mol-1
(will require importing Q from model, and reading time varying Q from file), and reading species molecular weight from file.Types of change(s)
Checklist
make tests
)Description
Related Issue