Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nearest-neighbor interpolation for ExtData #788

Merged

Conversation

rmontuoro
Copy link
Contributor

Description

This PR enables the nearest-neighbor interpolation method (MAPL option REGRID_METHOD_NEAREST_STOD) in ExtData.
This method can be selected using the E keyword in the ExtData resource file.

Related Issue

See issue #786.

Motivation and Context

The nearest-neighbor interpolation method is required to properly read selected land surface properties.

How Has This Been Tested?

These changes have been tested with UFS-GOCART on the Hera platform (NOAA RDHPCS).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@rmontuoro rmontuoro added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Apr 5, 2021
@rmontuoro rmontuoro requested review from tclune and bena-nasa April 5, 2021 20:01
@rmontuoro rmontuoro self-assigned this Apr 5, 2021
@rmontuoro rmontuoro requested a review from a team as a code owner April 5, 2021 20:01
@rmontuoro rmontuoro linked an issue Apr 5, 2021 that may be closed by this pull request
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine, but want @bena-nasa to review as well.

@bena-nasa bena-nasa merged commit 93e3ec0 into develop Apr 8, 2021
@bena-nasa bena-nasa deleted the feature/rmontuoro/#786-nearest-neighbor-interpolation branch April 8, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable nearest neighbor interpolation in ExtData
3 participants