Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in configuration #17

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Fix in configuration #17

merged 1 commit into from
Jul 22, 2021

Conversation

yvikhlya
Copy link

This PR fixes two issues in MOM5 configuration:

  • River spread bug in 1/4 degree setup
  • Changes reference year in diag_table to 1900, to make different netcdf tools stop complaining about time scale in MOM diagnostic files.

@yvikhlya yvikhlya self-assigned this Mar 12, 2021
@yvikhlya yvikhlya requested a review from a team March 12, 2021 17:54
sanAkel
sanAkel reviewed Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@sanAkel sanAkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these being ported from S2S v3?

data/geos5/1440x1080/INPUT/input.nml
/

&ocean_riverspread_nml
use_this_module=.true.
debug_this_module=.false
riverspread_diffusion=.true.
riverspread_diffusion_passes=500
vel_micom_smooth=2.0
riverspread_diffusion_passes=2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this being ported from S2S v3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@mathomp4
Copy link
Member

@sanAkel @yvikhlya I'm thinking of making a new release of MOM5 because of a simple dumb PR I made (#18).

Should we pull this into the release as well?

@yvikhlya yvikhlya merged commit d5fb80f into geos5 Jul 22, 2021
@yvikhlya yvikhlya deleted the bugfix/yury/config-fix branch July 22, 2021 21:34
@yvikhlya
Copy link
Author

This was supposed to be merged long time ago.

@yvikhlya
Copy link
Author

@sanAkel @yvikhlya I'm thinking of making a new release of MOM5 because of a simple dumb PR I made (#18).

Should we pull this into the release as well?

Yes, sure.

@mathomp4
Copy link
Member

@yvikhlya Query: Is this non-zero-diff for MOM5?

@yvikhlya
Copy link
Author

@yvikhlya Query: Is this non-zero-diff for MOM5?

This is zero diff in all resolutions, except 1/4 degree. So, technically, no this is not exactly zero diff.

@mathomp4
Copy link
Member

@yvikhlya Query: Is this non-zero-diff for MOM5?

This is zero diff in all resolutions, except 1/4 degree. So, technically, no this is not exactly zero diff.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanAkel sanAkel sanAkel approved these changes

Assignees

@yvikhlya yvikhlya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yvikhlya @mathomp4 @sanAkel