Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing line from prior merge #29

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Conversation

rtodling
Copy link
Collaborator

I talked to Matt about this, there is a missing line from a prior merge of his; w/o it, CRTM complies but does not run properly in the context of GSI. After talking to Matt, I placed the missing line back.

@rtodling rtodling added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 11, 2023
@rtodling rtodling requested a review from a team as a code owner February 11, 2023 11:37
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rtodling -free is not portable and appears to be unnecessary here. All extant compilers (except IBM which we don't use) will by default assume free format for files with .f90 and .F90 suffixes.

If this is needed, just ping me and I'll go in and approve. And then will ask @mathomp4 to follow up by creating a patch for esma_cmake to include a generic option for forcing free format.

@mathomp4
Copy link
Member

@rtodling -free is not portable and appears to be unnecessary here. All extant compilers (except IBM which we don't use) will by default assume free format for files with .f90 and .F90 suffixes.

If this is needed, just ping me and I'll go in and approve. And then will ask @mathomp4 to follow up by creating a patch for esma_cmake to include a generic option for forcing free format.

Well, I just looked at Intel and that is the case:

              Description:

              This option specifies source files are in free format. If this option is not specified, format is determined as follows:

              o Files with an extension of .f90, .F90, or .i90 are free-format source files.

              o Files with an extension of .f, .for, .FOR, .ftn, or

So, I think the -free can be removed in this case. There are no .f files in the CRTM so everything is free format.

@mathomp4
Copy link
Member

I think for now we'll just let this get in as @rtodling has tested it. I'll make a PR to remove -free after we release to keep it clean.

First, though, I need to fix the CI. Hold please...

@mathomp4 mathomp4 self-requested a review February 13, 2023 13:39
@mathomp4 mathomp4 merged commit 24223d5 into main Feb 13, 2023
@mathomp4 mathomp4 deleted the bugfix/rtodling/crtm_comp_flags branch February 13, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants