Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use solar zenith angle from MAPL #1

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

mmanyin
Copy link
Contributor

@mmanyin mmanyin commented Mar 24, 2023

TR now calls a new wrapper (for getting SZA from MAPL) for all passive tracers using GMI dry deposition (e.g. Be7, Be10, Pb210). It is slightly non-zero-diff for these tracers.

This PR is zero-diff for the 4 tracers that are automatically configured to run by the 'setup' scripts.

This PR goes together with changes in the Chemistry and GMI repo's.
GEOS-ESM/GEOSchem_GridComp#255 (comment)
GEOS-ESM/GMI#3 (comment)

@mmanyin mmanyin added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff labels Mar 24, 2023
@mmanyin mmanyin requested a review from a team as a code owner March 24, 2023 18:09
@mmanyin mmanyin added the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 24, 2023
@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@mmanyin
Copy link
Contributor Author

mmanyin commented Mar 24, 2023

Need to verify the approach w/ P Norris

@github-actions
Copy link

This PR is being prevented from merging because you have added one of our blocking labels: Contingent - DNA, Needs Lead Approval, Contingent -- Do Not Approve. You'll need to remove it before this PR can be merged.

@mmanyin mmanyin removed the Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Mar 27, 2023
@mmanyin
Copy link
Contributor Author

mmanyin commented Mar 27, 2023

Removed "Contingent DNA" label, after verifying that the MAPL call is done correctly.

Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Peter is happy, I'm happy!

@mmanyin mmanyin merged commit 8c691cf into develop Mar 28, 2023
@mmanyin mmanyin deleted the feature/mmanyin/use_MAPL_SZA branch March 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants