Remove hardcoded /tmp from code_tests, and fix GEOS_mksi test #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This doesn't fully resolve the |
Since GEOS-ESM/GEOS_mksi#2 was merged, GEOS_mksi main and develop are now in sync. This was causing the GEOS_mksi test to fail. This changes the test to point to a known (very old!) version of GEOS_mksi that will cause an error, so the test actually passes.
ashiklom
force-pushed
the
bugfix/issue-432
branch
from
56ac732 to
709f940
Compare
ashiklom
changed the title
Dooruk
approved these changes
Oct 1, 2024
asewnath
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #432
Also, fixes an issue with the
GEOS_mksitest now thatGEOS_mksi@develophas been merged intomain(GEOS-ESM/GEOS_mksi#2).