Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] - installation from fork issue - tags #213

Closed
alexvalentine94 opened this issue Jun 11, 2024 · 1 comment
Closed

[DOC] - installation from fork issue - tags #213

alexvalentine94 opened this issue Jun 11, 2024 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@alexvalentine94
Copy link
Collaborator

What were you looking for

Help with installation for existing fork. This in the long term will not be a persistent problem now we have moved to semantic versioning however to avoid others running into some difficulty I faced with installation:

In the .toml file setuptools will use the git tags in your fork to determine the version number of your project. Later versions of setuptools require that the tags are compliant with PEP440 i.e. N.N[.N]. In my fork I had a single tag, 05102023v1 reflecting one of the releases of the code which does not conform to this standard causing the installation to fail.

To resolve this you can update the tags in your fork using git fetch --tags where the remote-url is that of the original repository. Push these changes with git push --tags. Then delete any of the tags not conforming to the standard.

Is the information available in the doc but not where you would expect?

No

Is information completely lacking or partial?

currently not available.

Where would you insert the missing information?

Install instructions.

Additional context

It may be better to simplify the version number handling in the toml file - i.e. manual specification using version = "x.x.x".

@alexvalentine94 alexvalentine94 added the documentation Improvements or additions to documentation label Jun 11, 2024
@alexvalentine94 alexvalentine94 self-assigned this Jun 14, 2024
@alexvalentine94
Copy link
Collaborator Author

Agreed that this can be minor addition to documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant