passing specific args instead of class dict #122
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we pass a self.dict around to all the functions called.
This makes it difficult to know what functions need what data
knowing what functions need what data helps with a refactoring
while this is less concise than passing the whole class dictionary around it means we can see what is used where.
This PR is just a bare bones removal of the passing of the entire class dict
This makes it easier to create unit tests for individual function. Previously this would be difficult as one would have to make a complete CadToCsg class and pass that in as an argument
this large number of args passed from the class to the function suggests that the fucntion should be a class method instead. So we can follow this up with moving the function to the class, but first I'm keen to make all the information flow around the code clear