Avoid doubled underscore in method names #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f35b217.
psauvan
pushed a commit
that referenced
this pull request
Jun 17, 2024
* renamed functions with __ * removed random commit * Revert "removed random commit" This reverts commit f35b217.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid Using Double Underscore in Method Names: Method names like get_surface_table and simplify_planes are not recommended in Python. Double underscores should be used for special methods only (like init, str, etc.). For private methods, a single underscore prefix is recommended but I don't think any of these methods need to be private either. So I've renamed them all to not have the double underscores.
@alberto743 also spotted this unusual use of __
Checklist