Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving decompose solid into class #182

Closed
wants to merge 0 commits into from
Closed

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented May 20, 2024

Description

Just looking at the attributes used in decompose solid it save a bit of data passing around if we move the decompose solid into the CadToCsg class. Save a few lines of code

The users will not see this function as it has been made private, so no changes to the user workflow. But I think this is the first step towards letting users perform the decomposition as a separate step

Checklist

  • I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
  • I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant