Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need for os import #185

Merged
merged 7 commits into from
May 22, 2024

Conversation

shimwell
Copy link
Collaborator

Description

Tiny PR that reworks the path creation and checking of files exiting. Saves a few lines of code

Checklist

  • I'm making a PR from a feature branch on my fork into GEOUNED-org/GEOUNED/dev branch
  • I have followed PEP8 style guide for Python or run a formatter such as black or ruff format on my code

@shimwell
Copy link
Collaborator Author

this one is now passing the tests and ready for review if anyone has time

@shimwell
Copy link
Collaborator Author

solved merge conflicts

@psauvan psauvan merged commit cafe1a7 into GEOUNED-org:dev May 22, 2024
9 checks passed
psauvan pushed a commit that referenced this pull request Jun 17, 2024
* removed os.path and os.mkdir

* format

* defined folder

* passing str to exportStep

* format

* corrected argmument name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants