Adding UCARD to missing parts of documentation and example JSON file #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
commented
May 23, 2024
shimwell
commented
May 23, 2024
psauvan
pushed a commit
that referenced
this pull request
Jun 17, 2024
…194) * moved two methods out of start * removed unnecessary logger line * added UCARD null to missing parts * full step files list * added check for ucard above 1 * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation was missing
UCARDin a few placesmany thanks to @py1sl for spotting this
also added a check to ensure UCARD entry is above 0
default UCARD set to None instead of 101
There is a tiny complication the equivalent
Nonein JSON isnulland can't acceptNoneso I've added a note on this to the docsChecklist