Update reverse to JSON and rename to CsgToCad #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this one is ready for review if anyone has time |
4 tasks
psauvan
pushed a commit
that referenced
this pull request
Jun 17, 2024
* moved two methods out of start * removed unnecessary logger line * started CsgToCad class definition * added class * added cli for csgtocad method * restructure docs * adding csgtocad to docs * improved csg to cad examples * format * corrected json path * moved doc string to method * corrected file path * quotes used in dict * removed old code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #193 by adding docs, tests and examples for the CsgToCad class
Description
This PR aims to get the reverse function working and tested
Checklist