fix(docker): reduce size of image by about half #381
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be ideal if some build tool could minify the dependencies and only include what is needed, like vite does for the frontend. But that's not super needed, and I think requires quite a lot more changes. |
|
@SuperVK we could switch to vite? |
JustSamuel
approved these changes
Oct 28, 2024
JustSamuel
force-pushed
the
fix/docker-size
branch
from
1d665ac to
73d4385
Compare
|
I don't really follow why this reduces the size of the image, probably because you do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Ubuntu Summit I was lead down a rabbit hole of inspecting docker images. I noticed that the sudosos-backend could use some improvement.
Description
I noticed that the npm ci still installed dev dependencies in the runtime container, so that was fixed. Furthermore when installing npm packages, it also adds to the cache. Meaning it used to have 2x the node_modules installed in the image. By installing in the build container and copying to the runtime container, we circumvent this issue.
The build from 6 days ago is the current develop docker image, the docker image from 9 minutes ago is this the one that has the improvement.
Here you can see the cache being added which is about the same size as the node_modules themself:
My improved image is currently running on develop (28-10-2024 10:53), it seems to work, only the pdf is broken, but pretty sure that has always been broken on develop?
Related issues/external references
Types of changes