Small fixes #192
Merged
Small fixes #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your interest and the PR! I am looking now. |
josephdviviano
approved these changes
Oct 11, 2024
| @@ -36,7 +36,7 @@ pip install torchgfn[scripts] | |||
| To install the cutting edge version (from the `main` branch): | |||
|
|
|||
| ```bash | |||
| git clone https://github.com/saleml/torchgfn.git | |||
| git clone https://github.com/GFNOrg/torchgfn.git | |||
There was a problem hiding this comment.
Oops, great catch, thank you.
| @@ -155,16 +155,15 @@ def _add_objs(self, training_objects: Transitions | Trajectories | tuple[States] | |||
|
|
|||
| # Add the terminating states to the buffer. | |||
| if self.terminating_states is not None: | |||
| assert terminating_states is not None | |||
| self.terminating_states.extend(terminating_states) | |||
| assert self.terminating_states is not None | |||
There was a problem hiding this comment.
Again, thank you. Ideally I would have written a test to catch this. I've filed an issue on this here #198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
I am currently exploring the project’s source code, and I came across these small bugs which I took the liberty of fixing.
I've also modified the git repository address in the README because the owner has changed since.
Thank you for this project, and I hope to contribute more deeply to it in the future.