Fix notebooks

[josephdviviano]

Fixes the smiley and simple continuous notebook to properly use the current torchgfn API.

[younik]

LGTM! I have reproduced the output on my laptop, which is good.

I have a couple of questions. Unfortunately, I cannot comment on diff.

env = LineEnvironment(
-   mus=[-2, 4, 6, 10],
+   mus=[-3, 4, 6, 10],
    variances=[0.2, 0.4, 1, 0.2],
    n_sd=4.5,
    init_value=0
)

What is the rationale for this change (cell 16, continuous line tutorial)?

-def make_States_class(self) -> type[DiscreteStates]:
-  ...
+# def make_States_class(self) -> type[DiscreteStates]:
+#  ...

In the smiley tutorial, you commented out this function, as it is not necessary... can we just delete it?

[josephdviviano]

Good catch. I'm not sure why, but leaving the value at -2 created a plotting error. I couldn't figure out how to fix the plotting error and the number itself is inconsequential. I'll remove the commented out bits. Joseph Viviano @josephdviviano <https://twitter.com/josephdviviano> viviano.ca

…

On Sat, Nov 9, 2024 at 6:37 AM Omar Younis ***@***.***> wrote: ***@***.**** commented on this pull request. LGTM! I have reproduced the output on my laptop, which is good. I have a couple of questions. Unfortunately, I cannot comment on diff <https://github.blog/changelog/2023-03-01-feature-preview-rich-jupyter-notebook-diffs/> . env = LineEnvironment(- mus=[-2, 4, 6, 10],+ mus=[-3, 4, 6, 10], variances=[0.2, 0.4, 1, 0.2], n_sd=4.5, init_value=0 ) What is the rationale for this change (cell 16, continuous line tutorial)? -def make_States_class(self) -> type[DiscreteStates]:- ...+# def make_States_class(self) -> type[DiscreteStates]:+# ... In the smiley tutorial, you commented out this function, as it is not necessary... can we just delete it? — Reply to this email directly, view it on GitHub <#212 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7TL2WTHLP46A7OBPCKXY3Z7XXZJAVCNFSM6AAAAABROORYOOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRVGI4TOMZTGI> . You are receiving this because you were assigned.Message ID: ***@***.***>

[alip67]

I reproduced the output on colab, which is good. A few Suggestion:
1- Add !pip install trochgfn in the start of the Torchgfn section.
2- change the env.mask_invalid_actions in the FacesEnv to the self.mask_invalid_actions
3- Add a colab link for all of the notebooks

[josephdviviano]

Thanks good catch @alip67 RE: env. vs self.. OTOH, I don't really want to support colab, these notebooks are designed to be run on your local machine.