Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite report aggregation of indicator to use mean value of indicator result class values #372

Merged
merged 28 commits into from
Oct 11, 2022

Conversation

matthiasschaub
Copy link
Collaborator

@matthiasschaub matthiasschaub commented Jul 6, 2022

Description

  • rewrite report aggregation of indicator to use mean value of indicator result class values
  • make indicator/layer combinations an attribute
  • fix typing in report base class

Corresponding issue

Closes #322, #263

Checklist

@matthiasschaub matthiasschaub added the waiting An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked label Jul 7, 2022
@matthiasschaub matthiasschaub requested review from Gigaszi and removed request for Gigaszi July 27, 2022 12:56
@Gigaszi Gigaszi marked this pull request as ready for review September 11, 2022 18:55
@Gigaszi Gigaszi added waiting for review This pull request urgently needs a code review and removed waiting An issue or PR which is waiting for an upstream bugfix, further information or is somehow blocked labels Sep 11, 2022
@matthiasschaub matthiasschaub added the priority:high Should be addressed as soon as possible (next release) label Sep 20, 2022
@matthiasschaub matthiasschaub added this to the Release 0.12.0 milestone Sep 20, 2022
Co-authored-by: Matthias Schaub <83658582+matthiasschaub@users.noreply.github.com>
Copy link
Collaborator Author

@matthiasschaub matthiasschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the code, run all the tests and tested it manually a bit. The changes look good to me!
I left one minor comment.

I think what would be good to have are tests for the blocking features. Maybe extending test_base_report with those tests would be a good idea.

CHANGELOG.md Outdated Show resolved Hide resolved
workers/tests/integrationtests/test_base_report.py Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub changed the title Report aggregation Rewrite report aggregation of indicator to use mean value of indicator result class values Oct 11, 2022
@matthiasschaub matthiasschaub merged commit 75cdee9 into main Oct 11, 2022
@matthiasschaub matthiasschaub deleted the report-aggregation branch October 11, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high Should be addressed as soon as possible (next release) report waiting for review This pull request urgently needs a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite aggregation of Indicators (result determination) of all Reports
2 participants