Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building-comparison: fix checks and result description #739

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

Gigaszi
Copy link
Collaborator

@Gigaszi Gigaszi commented Nov 9, 2023

Description

Please add a clear and concise description of what your PR solves.

Corresponding issue

Closes #733
Closes #731
Closes #735
Closes #732
Closes #737
Closes #734

New or changed dependencies

Checklist

  • I have updated my branch to main (e.g. through git rebase main)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have updated the CHANGELOG.md

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
tests/integrationtests/test_geodatabase.py Outdated Show resolved Hide resolved
@matthiasschaub matthiasschaub marked this pull request as ready for review November 14, 2023 13:13
@matthiasschaub matthiasschaub changed the title 🚧building-comparison: fix checks and result description building-comparison: fix checks and result description Nov 14, 2023
@ConstantinNicolai
Copy link
Collaborator

Pull request passed Jenkins pipeline

@ConstantinNicolai ConstantinNicolai merged commit c3be2a3 into main Nov 14, 2023
2 checks passed
@ConstantinNicolai ConstantinNicolai deleted the building-comparision-fix-up branch November 14, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment