Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert and rename app.config to ors-config.json #1017

Closed
4 of 5 tasks
TheGreatRefrigerator opened this issue Jul 21, 2021 · 0 comments · Fixed by #1020
Closed
4 of 5 tasks

Convert and rename app.config to ors-config.json #1017

TheGreatRefrigerator opened this issue Jul 21, 2021 · 0 comments · Fixed by #1020
Assignees
@TheGreatRefrigerator
Labels
cleanup enhancement | feature ⚡ infrastructure

Comments

@TheGreatRefrigerator
Copy link
Contributor

TheGreatRefrigerator commented Jul 21, 2021 •
edited
Loading

Why:

  • app.config already has JSON structure -> should be JSON file
  • automatic IDE linting etc.
  • further possibility to manage key-value access with json parser

What:

  • rename app.config throughout repo
  • deprecate app.config loading
    • default loading from ors-config.json
    • still support app.config but issue warning if loaded from or exists
  • rename in external sources e.g. ask forum
@TheGreatRefrigerator TheGreatRefrigerator self-assigned this Jul 21, 2021
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Deprecate app.config, ors_app_config and ORS_APP_CONFIG
e560938 
This deprecates the usage of, and issues warnings when using, the:
- 'app.config' file
- 'ors_app_config' system property
- 'ORS_APP_CONFIG' environment variable

The preferred alternatives are the:
- 'ors-config.json' file
- 'ors_config' system property
- 'ORS_CONFIG' environment variable

Also renames app.config.sample to ors-config-sample.json

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Consider deprecation in docker workflow
766ba93 
- rename deprecated names
- change `APP_CONFIG` argument to `ORS_CONFIG`
- extend output for config handling in docker-entrypoint.sh

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Use ors_config system property in tests
ae401d1 
refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Rename app.config
2baa7a1 
- in github workflow
- openrouteservice folder
- template files

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
docs: Rename Configuration-(app.config).md
e9fa8c1 
refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
docs: Rename remaining deprecated instances
4fc288e 
refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Deprecate app.config, ors_app_config and ORS_APP_CONFIG
32bdd0e 
This deprecates the usage of, and issues warnings when using, the:
- 'app.config' file
- 'ors_app_config' system property
- 'ORS_APP_CONFIG' environment variable

The preferred alternatives are the:
- 'ors-config.json' file
- 'ors_config' system property
- 'ORS_CONFIG' environment variable

Also renames app.config.sample to ors-config-sample.json

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Consider deprecation in docker workflow
76a29c6 
- rename deprecated names
- change `APP_CONFIG` argument to `ORS_CONFIG`
- extend output for config handling in docker-entrypoint.sh

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Use ors_config system property in tests
56eb0d6 
refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
Rename app.config
4e74fae 
- in github workflow
- openrouteservice folder
- template files

refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
docs: Rename Configuration-(app.config).md
54cdcaa 
refers to #1017
TheGreatRefrigerator added a commit that referenced this issue Jul 27, 2021
@TheGreatRefrigerator
docs: Rename remaining deprecated instances
e6b29ed 
refers to #1017
Merged
6 tasks
takb added a commit that referenced this issue Jul 28, 2021
@takb
Merge pull request #1020 from GIScience/feature/#1017-deprecate-app-c…
9227c3c 
…onfig

Feature/#1017 deprecate app config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheGreatRefrigerator TheGreatRefrigerator

Labels
cleanup enhancement | feature ⚡ infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/#1017 deprecate app config GIScience/openrouteservice
1 participant
@TheGreatRefrigerator