Return specific status code when route not found

[kontrollanten]

Current behavior:
When a route isn't found, a 500 HTTP status is returned with the following response

{
  "error":{
    "code":2099,
    "message":"Connection between locations not found"
  },
  "info":{
    "engine":{
      "version":"4.5.0",
      "build_date":"2018-02-27T14:22:36Z"
    },
    "timestamp":1520362248836
  }
}

Expected behavior
A 404 HTTP status code, or eventually an unique error code (not 2099, which is Unknown error).

According to this test case, it seems that it's by design:

openrouteservice/openrouteservice-api-tests/src/test/java/heigit/ors/services/routing/ResultTest.java

Line 722 in e703b6c

// Option 1 signifies that the route should not cross any borders

Is there any reason it is implemented like this?

Thanks!

[rabidllama]

Code has been updated so that a 2009 internal error code is returned with a 404 http response