Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of a manual/freehand route option #167

Closed
Martin868 opened this issue Apr 22, 2018 · 10 comments
Closed

Lack of a manual/freehand route option #167

Martin868 opened this issue Apr 22, 2018 · 10 comments

Comments

@Martin868
Copy link

On all the routing engines I know that allow the user to draw a route, there is on option to bypass routing for a section of the route and manually link two points. This option is handy when the route need to follow a missing way on the map, or that there is a routing error in the map database. I do a lot of cycling route planning and this happens all the time. For example the route planners in Strava, RideWithGPS, Garmin, all offer this. In ORS this should be a type of via point.

@nilsnolde
Copy link
Contributor

This is a frontend issue, please register it here:
https://github.com/GIScience/openrouteservice-app/issues

@TimMcCauley
Copy link
Contributor

TimMcCauley commented Apr 22, 2018

Frontend will consume this but it’s a feature that has to be implemented to the backend ultimately.

The idea is: if a direct connection should be returned the backend simply doesn’t optimize between those two waypoints. We have the code for this in an older version (which was implemented), I might be able to find it.

@dlichtistw
Copy link

I agree that this would be really useful for hiking route planning, too. I used it earlier, and am missing it now.

@rabidllama
Copy link
Contributor

@TimMcCauley Did you find where the old code was for this?

@TimMcCauley
Copy link
Contributor

TimMcCauley commented Aug 20, 2018

@rabidllama sorry, I checked and I can't find it (most likely on my old laptop which was stolen 👎). The idea is quite straightforward, every waypoint gets an additional attribute optimize which is either null (startpoint), true (find an optimized path between it and the previous wp) or false which won't optimize but return the input coordinates (between it and the previous wp) as flight of the crow.

wp1 | optimize: null
wp2 | optimize: true
wp3 | optimize: false

paths:
wp1 - wp2 => optimized path
wp2 - wp3 => flight of the crow

@rabidllama
Copy link
Contributor

OK, I don't think this will be too major a thing to add, so lets aim for getting it in there for v4.7

@rabidllama rabidllama added this to the 4.7 milestone Aug 21, 2018
@rabidllama rabidllama modified the milestones: 4.7, 4.7.2 Oct 12, 2018
@rabidllama
Copy link
Contributor

Moved to 4.7.2

@rabidllama rabidllama modified the milestones: 4.7.2, 5.0 Dec 17, 2018
MichaelsJP pushed a commit that referenced this issue Feb 10, 2019
MichaelsJP pushed a commit that referenced this issue Feb 10, 2019
MichaelsJP pushed a commit that referenced this issue Feb 11, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 12, 2019
MichaelsJP pushed a commit that referenced this issue Feb 13, 2019
@MichaelsJP
Copy link
Member

"coordinates": [[8.688812, 49.414352],[8.688169, 49.413193],[8.689349, 49.413291],[8.688898, 49.410652], [8.687375, 49.409549]]
auswahl_035
If you add "skip_segments": [3] it will add a direct connection between the third and fourth coordinate (third segment).
auswahl_036

@Martin868
Copy link
Author

Can it be done in the current front-end or this is coming ?

@TimMcCauley
Copy link
Contributor

@Martin868 yep, we will include this in the client as soon as it is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants