Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation data missing #394

Closed
samcrawford opened this issue Jan 15, 2019 · 15 comments · Fixed by #528
Closed

Elevation data missing #394

samcrawford opened this issue Jan 15, 2019 · 15 comments · Fixed by #528
Assignees
Labels
awaiting release ⏳ bug 🐞 Erroneous behavior of the backend graphhopper

Comments

@samcrawford
Copy link
Contributor

Here's what I did

  1. Installed ORS following the Docker instructions at https://github.com/GIScience/openrouteservice/blob/master/docker/README.md
  2. Imported my own OSM dataset (UK)
  3. I used the default app.config.sample otherwise. elevation=true is set throughout.
  4. Install the ORS-app and configured it to point the directions API at my new Docker instance

Here's what I got

The elevation profile showed no elevation gain/loss in the UI. I can see from the JSON response from API that the elevation values are all set to zero.

Here's what I tried

Additionally, I saw in the release notes for 4.7:

Added support for elevation data above & and below the 60 deg N/S. When you run your own instance make sure that you specify the elevation_provider: multi (instead of just 'cgiar') (Issue #220)
Added support to keep elevation source data over various path generation processes - add to your app.config: elevation_cache_clear: false

I made these changes in my app.config, and deleted the data/graphs directory, but it made no difference.

Here's what I was expecting

I was expecting to see elevation profile data in the UI. This works on the live maps.openrouteservice.org instance, so I suspect there's a config issue in the sample somewhere.

Sample request and response

Request:

http://localhost:8080/ors/routes?attributes=detourfactor%7Cpercentage&coordinates=0.012002,51.482953%7C-0.093372,51.506674&elevation=true&extra_info=steepness%7Cwaytype%7Csurface&geometry=true&geometry_format=geojson&instructions=true&instructions_format=html&language=en-US&preference=shortest&profile=foot-walking&units=m

Response:

{"routes":[{"elevation":true,"summary":{"distance":8902.4,"duration":6409.6},"geometry_format":"geojson","geometry":{"type":"LineString","coordinates":[[0.01207,51.482773,0],[0.011939,51.482753,0],[0.011631,51.482725,0],[0.011062,51.482712,0],[0.010996,51.482711,0],[0.01036,51.482705,0],[0.008586,51.482594,0],[0.008414,51.482582,0],[0.00839,51.482868,0],[0.008384,51.482935,0],[0.008274,51.48293,0],[0.008094,51.482911,0],[0.005819,51.482568,0],[0.005241,51.482509,0],[0.00515,51.482499,0],[0.004842,51.482462,0],[0.004706,51.482522,0],[0.003385,51.482498,0],[0.003287,51.482476,0],[0.003181,51.482411,0],[0.003099,51.482386,0],[0.00301,51.482378,0],[0.002925,51.482385,0],[0.002823,51.482413,0],[0.002708,51.482479,0],[0.002591,51.48252,0],[0.002422,51.482554,0],[0.002127,51.482582,0],[0.00185,51.482568,0],[0.001659,51.482547,0],[0.001621,51.482662,0],[0.001569,51.482789,0],[0.001499,51.482951,0],[0.001306,51.483346,0],[8.48E-4,51.483864,0],[7.04E-4,51.483814,0],[-1.38E-4,51.483603,0],[-2.68E-4,51.483562,0],[-3.92E-4,51.483524,0],[-5.16E-4,51.483491,0],[-7.65E-4,51.483426,0],[-9.0E-4,51.483396,0],[-0.001152,51.483346,0],[-0.001441,51.483283,0],[-0.001863,51.483192,0],[-0.002293,51.483099,0],[-0.002726,51.482969,0],[-0.002975,51.482892,0],[-0.003114,51.482846,0],[-0.003276,51.482795,0],[-0.003371,51.482764,0],[-0.004728,51.482302,0],[-0.004753,51.482294,0],[-0.00606,51.48185,0],[-0.006623,51.481674,0],[-0.006709,51.481644,0],[-0.007834,51.481251,0],[-0.008102,51.481162,0],[-0.008616,51.480986,0],[-0.008889,51.480889,0],[-0.009121,51.480812,0],[-0.009206,51.480814,0],[-0.009331,51.480824,0],[-0.00949,51.48086,0],[-0.00953,51.480896,0],[-0.009699,51.481023,0],[-0.009894,51.481194,0],[-0.009929,51.481228,0],[-0.009953,51.481249,0],[-0.010101,51.48132,0],[-0.010276,51.481374,0],[-0.010425,51.481414,0],[-0.010944,51.481427,0],[-0.01113,51.481427,0],[-0.011544,51.481428,0],[-0.013155,51.481431,0],[-0.013473,51.481433,0],[-0.013876,51.481425,0],[-0.014646,51.48141,0],[-0.014797,51.481407,0],[-0.014943,51.481402,0],[-0.01506,51.481397,0],[-0.015132,51.481435,0],[-0.01519,51.481433,0],[-0.016106,51.481406,0],[-0.016407,51.481399,0],[-0.016925,51.481387,0],[-0.017054,51.481363,0],[-0.017176,51.481342,0],[-0.017659,51.481317,0],[-0.018242,51.481264,0],[-0.018979,51.481197,0],[-0.019127,51.481183,0],[-0.020587,51.480999,0],[-0.021334,51.480932,0],[-0.021733,51.480887,0],[-0.021923,51.480907,0],[-0.022637,51.480843,0],[-0.022844,51.48085,0],[-0.022968,51.480857,0],[-0.023175,51.48089,0],[-0.02351,51.480955,0],[-0.023766,51.480974,0],[-0.024145,51.481025,0],[-0.02478,51.481177,0],[-0.025014,51.481224,0],[-0.025427,51.481314,0],[-0.02602,51.481433,0],[-0.026058,51.481441,0],[-0.026087,51.481446,0],[-0.026371,51.481504,0],[-0.026539,51.48154,0],[-0.026573,51.481548,0],[-0.026906,51.481631,0],[-0.027204,51.481735,0],[-0.027457,51.481814,0],[-0.027511,51.481834,0],[-0.027548,51.481848,0],[-0.02772,51.48191,0],[-0.028045,51.482035,0],[-0.028208,51.482101,0],[-0.028573,51.482262,0],[-0.028903,51.482415,0],[-0.029029,51.482473,0],[-0.029219,51.482564,0],[-0.029755,51.482829,0],[-0.03006,51.482979,0],[-0.03038,51.483142,0],[-0.0305,51.483175,0],[-0.030671,51.48326,0],[-0.030751,51.483327,0],[-0.030886,51.483372,0],[-0.031151,51.483504,0],[-0.031218,51.483541,0],[-0.03134,51.483608,0],[-0.031762,51.483808,0],[-0.031809,51.483831,0],[-0.031988,51.483917,0],[-0.032105,51.483951,0],[-0.032249,51.484027,0],[-0.032434,51.484145,0],[-0.032714,51.484286,0],[-0.032816,51.484351,0],[-0.033113,51.484575,0],[-0.033417,51.484815,0],[-0.034116,51.485386,0],[-0.034236,51.485466,0],[-0.034778,51.485852,0],[-0.034873,51.485927,0],[-0.035324,51.486277,0],[-0.035498,51.486412,0],[-0.035659,51.48652,0],[-0.036149,51.48681,0],[-0.036464,51.486959,0],[-0.03734,51.487373,0],[-0.037723,51.487614,0],[-0.03777,51.487643,0],[-0.038364,51.487948,0],[-0.039016,51.488282,0],[-0.03939,51.488482,0],[-0.039752,51.488668,0],[-0.040136,51.488855,0],[-0.040401,51.488997,0],[-0.040501,51.489053,0],[-0.040725,51.489165,0],[-0.040948,51.489297,0],[-0.041039,51.489345,0],[-0.041224,51.489455,0],[-0.041521,51.48963,0],[-0.041622,51.489695,0],[-0.041844,51.489836,0],[-0.041972,51.48992,0],[-0.042087,51.489994,0],[-0.042129,51.490045,0],[-0.042245,51.490119,0],[-0.042364,51.490198,0],[-0.042429,51.49021,0],[-0.042488,51.490253,0],[-0.042566,51.490307,0],[-0.043508,51.490976,0],[-0.043905,51.491241,0],[-0.044544,51.491692,0],[-0.044607,51.491739,0],[-0.044702,51.491809,0],[-0.044915,51.491797,0],[-0.045096,51.491787,0],[-0.045281,51.491778,0],[-0.045564,51.491751,0],[-0.045726,51.491716,0],[-0.045882,51.491704,0],[-0.046215,51.491663,0],[-0.046384,51.491636,0],[-0.046551,51.491611,0],[-0.046806,51.49157,0],[-0.046916,51.491585,0],[-0.046997,51.491598,0],[-0.047076,51.491651,0],[-0.047142,51.491748,0],[-0.047293,51.492126,0],[-0.047443,51.492458,0],[-0.047672,51.492773,0],[-0.048011,51.493239,0],[-0.048141,51.493416,0],[-0.048294,51.493598,0],[-0.048322,51.493648,0],[-0.048336,51.49367,0],[-0.04835,51.49369,0],[-0.048368,51.493716,0],[-0.048471,51.493805,0],[-0.0487,51.493931,0],[-0.048876,51.494048,0],[-0.048979,51.494095,0],[-0.049777,51.494438,0],[-0.049878,51.494487,0],[-0.050123,51.49461,0],[-0.050222,51.494674,0],[-0.050323,51.494746,0],[-0.050607,51.49497,0],[-0.05091,51.495216,0],[-0.050945,51.495246,0],[-0.05139,51.495578,0],[-0.051432,51.495608,0],[-0.051487,51.495647,0],[-0.051766,51.495859,0],[-0.051973,51.496027,0],[-0.052216,51.496151,0],[-0.052387,51.496268,0],[-0.05251,51.496358,0],[-0.05259,51.496418,0],[-0.052813,51.496622,0],[-0.052837,51.496685,0],[-0.053016,51.496846,0],[-0.053329,51.497097,0],[-0.053427,51.497132,0],[-0.053584,51.497229,0],[-0.053959,51.497508,0],[-0.054659,51.498039,0],[-0.054765,51.498127,0],[-0.054952,51.498267,0],[-0.055285,51.498468,0],[-0.055378,51.498518,0],[-0.055503,51.498578,0],[-0.055767,51.498686,0],[-0.055889,51.498774,0],[-0.05612,51.498872,0],[-0.056211,51.498908,0],[-0.05648,51.498962,0],[-0.056659,51.498961,0],[-0.057722,51.498851,0],[-0.058419,51.498777,0],[-0.05936,51.498689,0],[-0.060222,51.498594,0],[-0.060288,51.498588,0],[-0.060495,51.498564,0],[-0.060668,51.498544,0],[-0.061324,51.49844,0],[-0.061715,51.498392,0],[-0.062128,51.498342,0],[-0.062768,51.498252,0],[-0.063473,51.498178,0],[-0.063491,51.498226,0],[-0.063942,51.49817,0],[-0.063986,51.498164,0],[-0.064869,51.498073,0],[-0.065104,51.498055,0],[-0.065392,51.498037,0],[-0.065495,51.498032,0],[-0.065696,51.498023,0],[-0.065862,51.498017,0],[-0.066143,51.498011,0],[-0.066334,51.498004,0],[-0.066569,51.498005,0],[-0.066749,51.498017,0],[-0.067194,51.498061,0],[-0.067334,51.49808,0],[-0.067465,51.498098,0],[-0.067925,51.498166,0],[-0.06915,51.498463,0],[-0.069406,51.498532,0],[-0.069511,51.498561,0],[-0.070127,51.498763,0],[-0.07069,51.499009,0],[-0.071065,51.499204,0],[-0.071448,51.499404,0],[-0.071927,51.499701,0],[-0.072229,51.499878,0],[-0.072571,51.500059,0],[-0.07288,51.500168,0],[-0.073696,51.500423,0],[-0.073938,51.500495,0],[-0.074105,51.500549,0],[-0.074298,51.500614,0],[-0.074304,51.500616,0],[-0.074357,51.50064,0],[-0.074884,51.500888,0],[-0.075653,51.501264,0],[-0.075693,51.501284,0],[-0.075941,51.501411,0],[-0.076313,51.501588,0],[-0.076602,51.501784,0],[-0.07675,51.501885,0],[-0.077467,51.502396,0],[-0.077636,51.502484,0],[-0.078008,51.502707,0],[-0.078488,51.502995,0],[-0.078793,51.503103,0],[-0.079026,51.503178,0],[-0.079347,51.503291,0],[-0.079534,51.503357,0],[-0.079751,51.503433,0],[-0.079958,51.503495,0],[-0.079987,51.503504,0],[-0.080296,51.503589,0],[-0.080474,51.503639,0],[-0.080801,51.503726,0],[-0.081149,51.503861,0],[-0.081193,51.503879,0],[-0.081422,51.503971,0],[-0.081486,51.503995,0],[-0.081694,51.504079,0],[-0.081885,51.504156,0],[-0.082109,51.50424,0],[-0.082508,51.504384,0],[-0.082708,51.504456,0],[-0.082864,51.504512,0],[-0.083015,51.504568,0],[-0.083146,51.504616,0],[-0.083389,51.504709,0],[-0.083446,51.50473,0],[-0.083668,51.504817,0],[-0.083903,51.504909,0],[-0.08415,51.505007,0],[-0.084226,51.505037,0],[-0.084376,51.505096,0],[-0.084426,51.505115,0],[-0.084674,51.505225,0],[-0.084703,51.505238,0],[-0.084847,51.505299,0],[-0.085261,51.505471,0],[-0.085458,51.505551,0],[-0.08567,51.505639,0],[-0.085808,51.505683,0],[-0.085978,51.50573,0],[-0.086038,51.505747,0],[-0.086161,51.505775,0],[-0.086159,51.505798,0],[-0.086176,51.505849,0],[-0.086257,51.505946,0],[-0.086386,51.50602,0],[-0.086454,51.506055,0],[-0.086532,51.506095,0],[-0.086669,51.506154,0],[-0.086753,51.506185,0],[-0.086832,51.506211,0],[-0.087119,51.506294,0],[-0.087555,51.50635,0],[-0.087875,51.506391,0],[-0.088459,51.506469,0],[-0.088819,51.506518,0],[-0.089119,51.506567,0],[-0.089351,51.506604,0],[-0.089557,51.506638,0],[-0.089652,51.506653,0],[-0.089823,51.506683,0],[-0.089883,51.506688,0],[-0.08992,51.506666,0],[-0.089951,51.506605,0],[-0.089962,51.506587,0],[-0.090097,51.50637,0],[-0.090192,51.50629,0],[-0.090286,51.506406,0],[-0.090357,51.506543,0],[-0.090416,51.506575,0],[-0.09051,51.506623,0],[-0.090537,51.506673,0],[-0.090484,51.506821,0],[-0.090515,51.506874,0],[-0.090565,51.506881,0],[-0.090626,51.50689,0],[-0.091356,51.507,0],[-0.091689,51.507046,0],[-0.092621,51.507114,0],[-0.092734,51.507119,0],[-0.092753,51.507074,0],[-0.092787,51.506697,0],[-0.093309,51.506799,0]]},"segments":[{"distance":8902.4,"duration":6409.6,"detourfactor":1.15,"percentage":100,"steps":[{"distance":254.4,"duration":183.1,"type":11,"instruction":"Head west on <b>Humber Road<\/b>","name":"Humber Road","way_points":[0,7]},{"distance":39.3,"duration":28.3,"type":1,"instruction":"Turn right onto <b>Vanburgh Hill<\/b>","name":"Vanburgh Hill","way_points":[7,9]},{"distance":229.3,"duration":165.1,"type":0,"instruction":"Turn left onto <b>Restell Close<\/b>","name":"Restell Close","way_points":[9,14]},{"distance":254.3,"duration":183.1,"type":6,"instruction":"Continue straight","name":"","way_points":[14,29]},{"distance":157.9,"duration":113.7,"type":1,"instruction":"Turn right onto <b>Maze Hill<\/b>","name":"Maze Hill","way_points":[29,34]},{"distance":770.8,"duration":555,"type":0,"instruction":"Turn left onto <b>Trafalgar Road, A206<\/b>","name":"Trafalgar Road, A206","way_points":[34,60]},{"distance":26.3,"duration":18.9,"type":13,"instruction":"Keep right onto <b>Nelson Road, A206<\/b>","name":"Nelson Road, A206","way_points":[60,63]},{"distance":53.9,"duration":38.8,"type":5,"instruction":"Turn slight right onto <b>Greenwich Church Street, A206<\/b>","name":"Greenwich Church Street, A206","way_points":[63,68]},{"distance":358.8,"duration":258.3,"type":12,"instruction":"Keep left onto <b>Creek Road, A200<\/b>","name":"Creek Road, A200","way_points":[68,81]},{"distance":468.7,"duration":337.5,"type":5,"instruction":"Turn slight right onto <b>Creek Road, A200<\/b>","name":"Creek Road, A200","way_points":[81,95]},{"distance":86.3,"duration":62.2,"type":13,"instruction":"Keep right onto <b>Creek Road, A200<\/b>","name":"Creek Road, A200","way_points":[95,99]},{"distance":614.2,"duration":442.2,"type":13,"instruction":"Keep right onto <b>Evelyn Street, A200<\/b>","name":"Evelyn Street, A200","way_points":[99,130]},{"distance":1085,"duration":781.2,"type":12,"instruction":"Keep left onto <b>Evelyn Street, A200<\/b>","name":"Evelyn Street, A200","way_points":[130,172]},{"distance":34.6,"duration":24.9,"type":13,"instruction":"Keep right onto <b>Evelyn Street, A200<\/b>","name":"Evelyn Street, A200","way_points":[172,176]},{"distance":227.3,"duration":163.7,"type":5,"instruction":"Turn slight right onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[176,182]},{"distance":10.2,"duration":7.3,"type":6,"instruction":"Continue straight onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[182,183]},{"distance":148.6,"duration":107,"type":0,"instruction":"Turn left onto <b>Plough Way<\/b>","name":"Plough Way","way_points":[183,193]},{"distance":33.4,"duration":24,"type":13,"instruction":"Keep right onto <b>Rotherhithe New Road, A2208<\/b>","name":"Rotherhithe New Road, A2208","way_points":[193,197]},{"distance":198.6,"duration":143,"type":6,"instruction":"Continue straight onto <b>Rotherhithe Old Road<\/b>","name":"Rotherhithe Old Road","way_points":[197,202]},{"distance":88.2,"duration":63.5,"type":6,"instruction":"Continue straight onto <b>Rotherhithe Old Road<\/b>","name":"Rotherhithe Old Road","way_points":[202,210]},{"distance":309.7,"duration":223,"type":6,"instruction":"Continue straight onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[210,224]},{"distance":152.9,"duration":110.1,"type":12,"instruction":"Keep left onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[224,232]},{"distance":172.4,"duration":124.1,"type":12,"instruction":"Keep left onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[232,238]},{"distance":625.1,"duration":450.1,"type":12,"instruction":"Keep left onto <b>Lower Road, A200<\/b>","name":"Lower Road, A200","way_points":[238,259]},{"distance":5.5,"duration":4,"type":1,"instruction":"Turn right onto <b>Keeton's Road<\/b>","name":"Keeton's Road","way_points":[259,260]},{"distance":806,"duration":580.3,"type":0,"instruction":"Turn left onto <b>Jamaica Road, A200<\/b>","name":"Jamaica Road, A200","way_points":[260,289]},{"distance":1037.8,"duration":747.2,"type":6,"instruction":"Continue straight onto <b>Tooley Street, A200<\/b>","name":"Tooley Street, A200","way_points":[289,344]},{"distance":288.5,"duration":207.7,"type":1,"instruction":"Turn right onto <b>Tooley Street<\/b>","name":"Tooley Street","way_points":[344,364]},{"distance":49.6,"duration":35.7,"type":0,"instruction":"Turn left onto <b>Montague Close<\/b>","name":"Montague Close","way_points":[364,369]},{"distance":35.9,"duration":25.8,"type":3,"instruction":"Turn sharp right onto <b>Cathedral Street<\/b>","name":"Cathedral Street","way_points":[369,372]},{"distance":31.1,"duration":22.4,"type":13,"instruction":"Keep right","name":"","way_points":[372,375]},{"distance":6.4,"duration":4.6,"type":4,"instruction":"Turn slight left","name":"","way_points":[375,376]},{"distance":156.2,"duration":112.5,"type":0,"instruction":"Turn left","name":"","way_points":[376,382]},{"distance":47.2,"duration":34,"type":0,"instruction":"Turn left","name":"","way_points":[382,384]},{"distance":37.8,"duration":27.2,"type":3,"instruction":"Turn sharp right","name":"","way_points":[384,385]},{"distance":0,"duration":0,"type":10,"instruction":"Arrive at your destination, on the left","name":"","way_points":[385,385]}]}],"way_points":[0,385],"extras":{"surface":{"values":[[0,14,3],[14,15,0],[15,357,3],[357,372,5],[372,376,0],[376,377,14],[377,379,3],[379,382,5],[382,385,3]],"summary":[{"value":3,"distance":8556.3,"amount":96.11},{"value":5,"distance":283.4,"amount":3.18},{"value":0,"distance":59.1,"amount":0.66},{"value":14,"distance":3.5,"amount":0.04}]},"waytypes":{"values":[[0,7,3],[7,9,2],[9,14,3],[14,15,7],[15,29,3],[29,34,2],[34,183,1],[183,185,3],[185,259,1],[259,260,3],[260,344,1],[344,372,3],[372,377,7],[377,380,3],[380,381,7],[381,382,2],[382,384,3],[384,385,2]],"summary":[{"value":1,"distance":7281.6,"amount":81.79},{"value":3,"distance":1250.3,"amount":14.04},{"value":2,"distance":242.9,"amount":2.73},{"value":7,"distance":127.6,"amount":1.43}]},"steepness":{"values":[[0,385,0]],"summary":[{"value":0,"distance":8902.4,"amount":100}]}},"bbox":[-0.093309,51.480812,0.01207,51.507119]}],"bbox":[-0.093309,51.480812,0.01207,51.507119],"info":{"attribution":"openrouteservice.org, OpenStreetMap contributors","engine":{"version":"4.7.0","build_date":"2019-01-13T11:31:04Z"},"service":"routing","timestamp":1547592926900,"query":{"profile":"foot-walking","preference":"shortest","coordinates":[[0.012002,51.482953,0],[-0.093372,51.506674,0]],"language":"en-US","units":"m","geometry":true,"geometry_format":"geojson","instructions_format":"html","instructions":true,"elevation":true}}}
@TimMcCauley
Copy link
Contributor

@samcrawford thanks for sharing this issue.

  • Could you please paste your app.config as a gist in here?
  • Could you also please paste the list of files of the cgiar_cache folder?

@samcrawford
Copy link
Contributor Author

samcrawford commented Jan 16, 2019

No problem.

  1. https://gist.github.com/samcrawford/7bf224b68df3b07fd2c299f982171f1c
  2. It's empty:
[root@osm data]# ll cgiar_provider/
total 0

I've just spotted the other difference between my config and the default, which is that I only enable the pedestrian-walk profile.

@TimMcCauley
Copy link
Contributor

@samcrawford this looks good so far - did the ors docker container have access to the internet at the time of building graphs?

@samcrawford
Copy link
Contributor Author

@TimMcCauley Yes, it definitely did (I was building this on a Linode machine). I also ran into the same issue on my local desktop, running with IDEA.

I will try a completely vanilla docker install tonight (using the Heidelberg dataset and your default config).

@samcrawford
Copy link
Contributor Author

Reset my local Git directory back to HEAD, re-ran the vanilla Docker instructions, and still no joy. This used the default config with zero changes. The docker/data/cgiar_provider directory now has this:

[root@osm docker]# ll data/cgiar_provider/
total 8
-rw-r----- 1 root root 228 Jan 21 21:58 srtm_36_02.gh
-rw-r----- 1 root root 228 Jan 21 21:58 srtm_37_02.gh

Note: the only change I made from default was to disable the OpenGeo repository in pom.xml to get it to build in a reasonable timeframe (I see there's another issue that's just fixed this).

@TimMcCauley
Copy link
Contributor

Hi Sam, sorry for my late responses, been quite busy lately - could you please try another region for now, let's say https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf and let me know what happens? It is very weird that it isn't generating the elevation information on the edges, at least the correct files have been downloaded properly.

@TimMcCauley
Copy link
Contributor

@samcrawford any updates from your side? Did you get it working?

@samcrawford
Copy link
Contributor Author

Sorry for the slow reply. I've retried with the region you suggested, and tried plotting a route there. Still no elevation data in the response.

The data/cgiar_provider directory is empty.

@TimMcCauley
Copy link
Contributor

Sam, could you please try

"elevation_provider": "cgiar",
"elevation_cache_path": "data/cgiar_provider",
"elevation_clear_cache": false,

?

@samcrawford
Copy link
Contributor Author

Thanks Tim. Just tried it, no joy, sorry.

I deleted the docker/build directory first, and the docker/data/cgiar_provider and docker/data/graphs directories too (to ensure a clean re-build). Then rebuilt with docker-compose up

My request (generated using the default parameters from the ORS web app):
http://localhost:8080/ors/routes?attributes=detourfactor%7Cpercentage&coordinates=9.538809,47.180105%7C9.520789,47.139801&elevation=true&extra_info=steepness%7Cwaytype%7Csurface&geometry=true&geometry_format=geojson&instructions=true&instructions_format=html&language=en-US&preference=fastest&profile=driving-car&units=m

The response:
{"routes":[{"elevation":true,"summary":{"distance":6919.4,"duration":661.8},"geometry_format":"geojson","geometry":{"type":"LineString","coordinates":[[9.538633,47.180169,0],[9.538189,47.1796,0],[9.538077,47.179395,0],[9.538009,47.179193,0],[9.537981,47.179028,0],[9.537948,47.178975,0],[9.537884,47.17894,0],[9.537817,47.178934,0],[9.537741,47.178956,0],[9.537688,47.179043,0],[9.537755,47.17926,0],[9.537777,47.180002,0],[9.537825,47.180186,0],[9.538035,47.180492,0],[9.538186,47.180608,0],[9.538421,47.180745,0],[9.538457,47.180853,0],[9.538429,47.180901,0],[9.538295,47.180935,0],[9.538155,47.180861,0],[9.536686,47.179633,0],[9.53665,47.179551,0],[9.536654,47.179469,0],[9.536748,47.179298,0],[9.536923,47.179111,0],[9.536942,47.179004,0],[9.536919,47.178857,0],[9.536836,47.178703,0],[9.536353,47.178248,0],[9.536325,47.178182,0],[9.536339,47.178085,0],[9.536398,47.178022,0],[9.536497,47.177966,0],[9.536729,47.177881,0],[9.536822,47.177828,0],[9.536883,47.177769,0],[9.536911,47.177669,0],[9.536869,47.177588,0],[9.53616,47.177021,0],[9.535858,47.176776,0],[9.535623,47.176571,0],[9.535569,47.176484,0],[9.535565,47.17637,0],[9.535589,47.17631,0],[9.535959,47.175989,0],[9.536086,47.17589,0],[9.536248,47.175837,0],[9.536404,47.175817,0],[9.536699,47.175814,0],[9.536897,47.175795,0],[9.537016,47.175746,0],[9.537087,47.175669,0],[9.537097,47.175618,0],[9.537097,47.175576,0],[9.537077,47.175535,0],[9.537022,47.175469,0],[9.536914,47.175404,0],[9.536673,47.175327,0],[9.536597,47.1753,0],[9.53621,47.175163,0],[9.536095,47.175125,0],[9.535868,47.175005,0],[9.535795,47.174821,0],[9.535799,47.174751,0],[9.535755,47.174695,0],[9.535676,47.174654,0],[9.535492,47.174643,0],[9.53542,47.174673,0],[9.535391,47.174713,0],[9.535426,47.174934,0],[9.535403,47.175011,0],[9.535349,47.17506,0],[9.535288,47.175087,0],[9.535207,47.175093,0],[9.535114,47.175072,0],[9.534957,47.17497,0],[9.534617,47.174643,0],[9.534534,47.174516,0],[9.534461,47.17433,0],[9.534457,47.174161,0],[9.53432,47.173637,0],[9.534302,47.173593,0],[9.534281,47.173541,0],[9.534188,47.173454,0],[9.534093,47.173395,0],[9.533901,47.173355,0],[9.532785,47.173285,0],[9.532012,47.173262,0],[9.531843,47.173274,0],[9.531622,47.173323,0],[9.531124,47.173434,0],[9.530471,47.173586,0],[9.529964,47.173686,0],[9.529516,47.173701,0],[9.529187,47.173676,0],[9.528969,47.173633,0],[9.528429,47.173463,0],[9.527768,47.173248,0],[9.52642,47.172775,0],[9.525112,47.172264,0],[9.524157,47.171873,0],[9.524066,47.171818,0],[9.52379,47.171652,0],[9.523346,47.171387,0],[9.522884,47.171161,0],[9.522836,47.171139,0],[9.522151,47.17087,0],[9.521784,47.170747,0],[9.521312,47.170639,0],[9.520818,47.170546,0],[9.52055,47.17051,0],[9.520378,47.170504,0],[9.51963,47.170501,0],[9.519179,47.170505,0],[9.518677,47.170501,0],[9.518301,47.170493,0],[9.517925,47.170493,0],[9.51765,47.170491,0],[9.517492,47.170507,0],[9.517378,47.170535,0],[9.517157,47.170354,0],[9.516842,47.170096,0],[9.516551,47.169821,0],[9.516234,47.169492,0],[9.515978,47.169175,0],[9.51532,47.16836,0],[9.515289,47.168322,0],[9.515222,47.168235,0],[9.514897,47.16783,0],[9.514876,47.167804,0],[9.514767,47.167667,0],[9.513851,47.166566,0],[9.513754,47.166442,0],[9.513139,47.165657,0],[9.512797,47.165077,0],[9.512544,47.164464,0],[9.512457,47.164096,0],[9.512427,47.163971,0],[9.512389,47.163809,0],[9.512368,47.16369,0],[9.512266,47.162336,0],[9.512158,47.161735,0],[9.511946,47.161157,0],[9.511867,47.161015,0],[9.511589,47.160408,0],[9.510931,47.158966,0],[9.510802,47.158698,0],[9.510653,47.15848,0],[9.510527,47.158322,0],[9.510338,47.158194,0],[9.510145,47.158133,0],[9.509942,47.158113,0],[9.509595,47.158099,0],[9.509608,47.157956,0],[9.509603,47.157351,0],[9.509642,47.156917,0],[9.509759,47.15645,0],[9.509947,47.156108,0],[9.510033,47.156004,0],[9.510274,47.155597,0],[9.510331,47.15542,0],[9.510416,47.155038,0],[9.5105,47.154665,0],[9.510572,47.154356,0],[9.510671,47.153901,0],[9.510689,47.15381,0],[9.510718,47.153714,0],[9.510899,47.152933,0],[9.510951,47.152718,0],[9.510985,47.152547,0],[9.51105,47.152262,0],[9.511089,47.152056,0],[9.511176,47.151627,0],[9.511191,47.151545,0],[9.511222,47.151406,0],[9.511244,47.151317,0],[9.511266,47.151227,0],[9.511298,47.151044,0],[9.511404,47.150787,0],[9.511564,47.150503,0],[9.511586,47.150459,0],[9.51167,47.150291,0],[9.511744,47.150158,0],[9.511848,47.149933,0],[9.51188,47.149863,0],[9.511947,47.149703,0],[9.512126,47.149235,0],[9.512212,47.149029,0],[9.512606,47.148062,0],[9.512853,47.147572,0],[9.513168,47.147031,0],[9.513604,47.146496,0],[9.513778,47.146319,0],[9.514079,47.146005,0],[9.514107,47.145976,0],[9.514383,47.145659,0],[9.514636,47.145432,0],[9.514811,47.145303,0],[9.514935,47.145213,0],[9.514994,47.145172,0],[9.515583,47.144778,0],[9.515858,47.144616,0],[9.516131,47.144471,0],[9.516701,47.14418,0],[9.516925,47.144056,0],[9.518358,47.143191,0],[9.518597,47.143042,0],[9.518647,47.143011,0],[9.518769,47.14293,0],[9.51882,47.142895,0],[9.519251,47.142554,0],[9.520127,47.141915,0],[9.52036,47.141712,0],[9.520397,47.14168,0],[9.520478,47.141607,0],[9.520744,47.141377,0],[9.520806,47.141323,0],[9.520857,47.141278,0],[9.520883,47.141232,0],[9.520888,47.141161,0],[9.520878,47.141125,0],[9.520853,47.14111,0],[9.520797,47.141064,0],[9.520786,47.141046,0],[9.52078,47.141028,0],[9.520777,47.141001,0],[9.520788,47.140973,0],[9.520815,47.140948,0],[9.520851,47.1409,0],[9.52091,47.14077,0],[9.520951,47.140737,0],[9.520998,47.140669,0],[9.521224,47.140405,0],[9.521252,47.140375,0],[9.521275,47.14035,0],[9.521323,47.140295,0],[9.521432,47.140141,0],[9.521484,47.14004,0],[9.521343,47.140021,0],[9.521272,47.14001,0],[9.521204,47.140002,0],[9.521149,47.139987,0],[9.520893,47.139943,0],[9.520752,47.139923,0]]},"segments":[{"distance":6919.4,"duration":661.8,"detourfactor":1.48,"percentage":100,"steps":[{"distance":155.1,"duration":18.2,"type":11,"instruction":"Head southwest on <b>Planknerstrasse<\/b>","name":"Planknerstrasse","way_points":[0,7]},{"distance":2859.6,"duration":209.8,"type":5,"instruction":"Turn slight right onto <b>Planknerstrasse<\/b>","name":"Planknerstrasse","way_points":[7,119]},{"distance":1554.6,"duration":180.1,"type":0,"instruction":"Turn left onto <b>Im Kresta<\/b>","name":"Im Kresta","way_points":[119,152]},{"distance":2156.5,"duration":216,"type":0,"instruction":"Turn left onto <b>Landstrasse<\/b>","name":"Landstrasse","way_points":[152,220]},{"distance":136.6,"duration":27.4,"type":7,"instruction":"Enter the roundabout and take the 2nd exit onto <b>Äulestrasse<\/b>","name":"Äulestrasse","exit_number":2,"way_points":[220,237]},{"distance":21.6,"duration":3.9,"type":1,"instruction":"Turn right onto <b>Badwegli<\/b>","name":"Badwegli","way_points":[237,240]},{"distance":35.4,"duration":6.4,"type":12,"instruction":"Keep left onto <b>Badwegli<\/b>","name":"Badwegli","way_points":[240,243]},{"distance":0,"duration":0,"type":10,"instruction":"Arrive at Badwegli, on the left","name":"","way_points":[243,243]}]}],"way_points":[0,243],"extras":{"surface":{"values":[[0,243,3]],"summary":[{"value":3,"distance":6919.4,"amount":100}]},"waytypes":{"values":[[0,119,2],[119,138,3],[138,237,2],[237,243,3]],"summary":[{"value":2,"distance":6017,"amount":86.96},{"value":3,"distance":902.4,"amount":13.04}]},"steepness":{"values":[[0,243,0]],"summary":[{"value":0,"distance":6919.4,"amount":100}]}},"bbox":[9.509595,47.139923,9.538633,47.180935]}],"bbox":[9.509595,47.139923,9.538633,47.180935],"info":{"attribution":"openrouteservice.org, OpenStreetMap contributors","engine":{"version":"4.7.0","build_date":"2019-03-03T20:20:58Z"},"service":"routing","timestamp":1551644771304,"query":{"profile":"driving-car","preference":"fastest","coordinates":[[9.538809,47.180105,0],[9.520789,47.139801,0]],"language":"en-US","units":"m","geometry":true,"geometry_format":"geojson","instructions_format":"html","instructions":true,"elevation":true}}}

@TimMcCauley
Copy link
Contributor

TimMcCauley commented Mar 6, 2019

Sam, this is annoying me :-) - let's dig a little deeper. Could you please run graphhopper directly with docker and see if it downloads (note: we are depending on graphhopper for exactly this) ?

https://github.com/graphhopper/graphhopper#docker

p.s. remember to enable elevation in the graphhopper config

@samcrawford
Copy link
Contributor Author

I think I've found the cause of this issue, at long last.

I tried in the latest Graphhopper, as requested, and it worked fine.

I then tcpdump'd what ORS was doing differently, and I saw it was making the following HTTP request for CGIAR data:

GET http://srtm.csi.cgiar.org/SRT-ZIP/SRTM_V41/SRTM_Data_GeoTiff/srtm_38_03.zip
Which 301's to http://srtm.csi.cgiar.org/srt-zip/srtm_v41/srtm_data_geotiff/srtm_38_03.zip
Which then 404's !

Then I stumbled upon this graphhopper/graphhopper#1545 and the fix in graphhopper/graphhopper@a929938#diff-65cd8d32eb00ab42a6cb85a5a349ea9a

So GH changed the URL for the CGIAR provider in February to address the issue I hit.

Hopefully this helps!

@TimMcCauley
Copy link
Contributor

Uff, wow. Thanks for debugging this @samcrawford. We haven't had this issue because we are using the same cache over and over again which was generated before this change was introduced by the cgiar team.

We are currently working on an updated of the openrouteservice graphhopper fork to 0.12 which will incorporate the PR in graphhopper.

https://github.com/GIScience/graphhopper/blob/ors_0.12-upgrade/core/src/main/java/com/graphhopper/reader/dem/CGIARProvider.java

@rabidllama @sfendrich @takb let's keep this open until we have updated.

@TimMcCauley TimMcCauley added bug 🐞 Erroneous behavior of the backend graphhopper and removed help wanted 🙏 investigate 🔍 labels May 22, 2019
@TimMcCauley TimMcCauley assigned sfendrich and takb and unassigned TimMcCauley May 22, 2019
@nilsnolde nilsnolde assigned nilsnolde and unassigned sfendrich and takb May 22, 2019
@nilsnolde
Copy link
Contributor

That IS great @samcrawford thanks!

I'll change this in our GH fork. Too important to wait for so long.

@nilsnolde
Copy link
Contributor

I'll just re-open until it's in master

@nilsnolde nilsnolde reopened this May 29, 2019
nilsnolde pushed a commit that referenced this issue May 29, 2019
nilsnolde pushed a commit that referenced this issue May 29, 2019
@nilsnolde nilsnolde mentioned this issue May 29, 2019
12 tasks
nilsnolde pushed a commit that referenced this issue May 29, 2019
rabidllama pushed a commit that referenced this issue May 31, 2019
rabidllama pushed a commit that referenced this issue Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release ⏳ bug 🐞 Erroneous behavior of the backend graphhopper
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants