-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elevation data missing #394
Comments
@samcrawford thanks for sharing this issue.
|
No problem.
I've just spotted the other difference between my config and the default, which is that I only enable the pedestrian-walk profile. |
@samcrawford this looks good so far - did the ors docker container have access to the internet at the time of building graphs? |
@TimMcCauley Yes, it definitely did (I was building this on a Linode machine). I also ran into the same issue on my local desktop, running with IDEA. I will try a completely vanilla docker install tonight (using the Heidelberg dataset and your default config). |
Reset my local Git directory back to HEAD, re-ran the vanilla Docker instructions, and still no joy. This used the default config with zero changes. The docker/data/cgiar_provider directory now has this:
Note: the only change I made from default was to disable the OpenGeo repository in pom.xml to get it to build in a reasonable timeframe (I see there's another issue that's just fixed this). |
Hi Sam, sorry for my late responses, been quite busy lately - could you please try another region for now, let's say https://download.geofabrik.de/europe/liechtenstein-latest.osm.pbf and let me know what happens? It is very weird that it isn't generating the elevation information on the edges, at least the correct files have been downloaded properly. |
@samcrawford any updates from your side? Did you get it working? |
Sorry for the slow reply. I've retried with the region you suggested, and tried plotting a route there. Still no elevation data in the response. The data/cgiar_provider directory is empty. |
Sam, could you please try
? |
Thanks Tim. Just tried it, no joy, sorry. I deleted the docker/build directory first, and the docker/data/cgiar_provider and docker/data/graphs directories too (to ensure a clean re-build). Then rebuilt with My request (generated using the default parameters from the ORS web app): The response: |
Sam, this is annoying me :-) - let's dig a little deeper. Could you please run graphhopper directly with docker and see if it downloads (note: we are depending on graphhopper for exactly this) ? https://github.com/graphhopper/graphhopper#docker p.s. remember to enable elevation in the graphhopper config |
I think I've found the cause of this issue, at long last. I tried in the latest Graphhopper, as requested, and it worked fine. I then tcpdump'd what ORS was doing differently, and I saw it was making the following HTTP request for CGIAR data: GET http://srtm.csi.cgiar.org/SRT-ZIP/SRTM_V41/SRTM_Data_GeoTiff/srtm_38_03.zip Then I stumbled upon this graphhopper/graphhopper#1545 and the fix in graphhopper/graphhopper@a929938#diff-65cd8d32eb00ab42a6cb85a5a349ea9a So GH changed the URL for the CGIAR provider in February to address the issue I hit. Hopefully this helps! |
Uff, wow. Thanks for debugging this @samcrawford. We haven't had this issue because we are using the same cache over and over again which was generated before this change was introduced by the cgiar team. We are currently working on an updated of the openrouteservice graphhopper fork to 0.12 which will incorporate the PR in graphhopper. @rabidllama @sfendrich @takb let's keep this open until we have updated. |
That IS great @samcrawford thanks! I'll change this in our GH fork. Too important to wait for so long. |
I'll just re-open until it's in master |
Here's what I did
Here's what I got
The elevation profile showed no elevation gain/loss in the UI. I can see from the JSON response from API that the elevation values are all set to zero.
Here's what I tried
Additionally, I saw in the release notes for 4.7:
I made these changes in my app.config, and deleted the data/graphs directory, but it made no difference.
Here's what I was expecting
I was expecting to see elevation profile data in the UI. This works on the live maps.openrouteservice.org instance, so I suspect there's a config issue in the sample somewhere.
Sample request and response
Request:
Response:
The text was updated successfully, but these errors were encountered: