Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong coordinate order in isochrones bounding box #493

Closed
aoles opened this issue Apr 8, 2019 · 6 comments
Closed

Wrong coordinate order in isochrones bounding box #493

aoles opened this issue Apr 8, 2019 · 6 comments
Assignees
Labels
awaiting release ⏳ bug 🐞 Erroneous behavior of the backend
Milestone

Comments

@aoles
Copy link
Member

aoles commented Apr 8, 2019

The bounding box returned for isochrones seems to have the coordinates ordered as

max Longitude, min Longitude, max Latitude, min Latitude

However, according to the geoJSON specification these should be rather in the order

min Longitude , min Latitude , max Longitude , max Latitude

The value of the bbox member MUST be an array of
length 2*n where n is the number of dimensions represented in the
contained geometries, with all axes of the most southwesterly point
followed by all axes of the more northeasterly point. The axes order
of a bbox follows the axes order of geometries.

This problem is evident in API playground where for the default example yields

"bbox" :  [ 8.701228 , 8.658792, 49.436847, 49.406197 ]  

The directions endpoint doesn't seem to be affected.

@aoles aoles added the bug 🐞 Erroneous behavior of the backend label Apr 8, 2019
@aoles aoles changed the title Wrong coordinate order bounding box for isochrones Wrong coordinate order in isochrones bounding box Apr 8, 2019
@nilsnolde nilsnolde self-assigned this Apr 8, 2019
@nilsnolde
Copy link
Contributor

I'll take the cheap one.

@aoles
Copy link
Member Author

aoles commented Apr 9, 2019

As this is a rather serious bug which renders the bounding box unusable we should consider publishing the fix without any unnecessary delay, certainly before ORS 5.2.

@nilsnolde
Copy link
Contributor

it's alright, not that crazy serious. not a single issue reported so far. I can take care of it on Thursday. Feel free to quickly do it if you want.

@aoles
Copy link
Member Author

aoles commented Apr 9, 2019

Thanks @nilsnolde ! No stress, but it's important in the sense that anyone trying to visualize the isochrones will probably run across this issue, at least that was the case for me as soon as I updated the R package to API v2.

@nilsnolde
Copy link
Contributor

Not every implementation takes bbox into account necessarily. We're displaying them into our web app without issues.

@aoles
Copy link
Member Author

aoles commented Apr 9, 2019

We're displaying them into our web app without issues.

This might be just because maps.openrouteservice.org still queries the legacy API. I didn't experience the issue with API v1 either but only after upgrading to API v2.

rabidllama pushed a commit that referenced this issue Apr 11, 2019
* [bugfix] isochrone geojson bbox is now compliant

* add isochrone bbox api-test

* changelog update
@rabidllama rabidllama added this to the 5.1 milestone Apr 11, 2019
TimMcCauley pushed a commit that referenced this issue May 23, 2019
* [bugfix] isochrone geojson bbox is now compliant

* add isochrone bbox api-test

* changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release ⏳ bug 🐞 Erroneous behavior of the backend
Projects
None yet
Development

No branches or pull requests

3 participants