Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isochrone response summary gives wrong 'range' when units != m #91

Closed
nilsnolde opened this issue Jan 31, 2018 · 1 comment
Closed

Isochrone response summary gives wrong 'range' when units != m #91

nilsnolde opened this issue Jan 31, 2018 · 1 comment
Assignees
@aoles @HendrikLeuschner
Labels
bug 🐞 Erroneous behavior of the backend
Milestone
4.7

Comments

@nilsnolde
Copy link
Contributor

nilsnolde commented Jan 31, 2018 •
edited
Loading

When specifying units=km/mi, the returned request summary specifies range in meter values.

Here a response for range=6 and units=mi:

...
 "service": "isochrones",
    "query": {
      "ranges": "9656.039999999999",
      "profile": "driving-car",
      "locations": [
        [
          8.34234,
          48.23424
        ]
      ],
      "units": "mi",
      "range_type": "distance",
      "location_type": "start"
    },
    "attribution": "openrouteservice.org | OpenStreetMap contributors",
    "timestamp": 1517404861719
  }
}
@nilsnolde nilsnolde added the bug 🐞 Erroneous behavior of the backend label Jan 31, 2018
@TimMcCauley TimMcCauley modified the milestone: 4.5 Feb 7, 2018
@rabidllama rabidllama added this to the 4.5.1 milestone Feb 27, 2018
@rabidllama rabidllama modified the milestones: 4.5.1, 4.5.2 Mar 20, 2018
@rabidllama rabidllama assigned aoles and HendrikLeuschner and unassigned Elli96 Jul 6, 2018
@rabidllama rabidllama modified the milestones: 4.5.2, 4.7 Jul 6, 2018
@HendrikLeuschner
Copy link
Collaborator

Fixed in #223

@HendrikLeuschner HendrikLeuschner mentioned this issue Jul 30, 2018
Merged
11 tasks
rabidllama added a commit that referenced this issue Jul 30, 2018
@rabidllama
Merge pull request #223 from GIScience/bugfix_issue_91
5c2183c 
Bugfix issue #91
@aoles aoles mentioned this issue Sep 24, 2018
Closed
@itsozz itsozz mentioned this issue May 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aoles aoles

@HendrikLeuschner HendrikLeuschner

Labels
bug 🐞 Erroneous behavior of the backend
Projects
None yet
Milestone
4.7
Development

No branches or pull requests
6 participants
@aoles @rabidllama @TimMcCauley @HendrikLeuschner @nilsnolde @Elli96