Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Comparison test for CH and RPHAST, but leave commented out #1147

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

HendrikLeuschner
Copy link
Collaborator

@HendrikLeuschner HendrikLeuschner commented Mar 29, 2022

Please check whether the changes to pom are ok before merge. Removed junit and added jqwik instead.
Also changed maven surefire version.

Leaving the test commented out because there are some runs when there is a failure, which still needs to be investigated.

@HendrikLeuschner HendrikLeuschner requested review from jlink and takb March 29, 2022 09:17
Copy link
Contributor

@jlink jlink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in JUnit, JUnit Platform and jqwik dependencies look good to me.

Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takb takb merged commit 24d777e into gh-4.0-upgrade-compiling Mar 30, 2022
@takb takb deleted the prop_tests_CH_RPHAST branch March 31, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants