Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix geocoding error code #117

Closed
wants to merge 4 commits into from
Closed

Conversation

rabidllama
Copy link
Contributor

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading
  • 3. I have documented my code using JDocs tags
  • 4. I have removed unecessary commented out code, imports and System.out.println statements

- [ ] 5. I have written JUnit tests for any new methods/classes and ensured that they pass

  • 6. I have created API tests for any new functionality exposed to the API

- [ ] 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below)

  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue)

- [ ] 10. For new features involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors)

  • 11. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #113 .

Information about the changes

Required changes to app.config (if applicable)

  • None

@rabidllama
Copy link
Contributor Author

@TheGreatRefrigerator - can you check that this won't cause issues on the front end with ajax handling?

@MichaelsJP MichaelsJP closed this Feb 22, 2018
@rabidllama rabidllama reopened this Feb 22, 2018
@rabidllama rabidllama closed this Feb 22, 2018
@rabidllama rabidllama deleted the fix_geocoding_error_code branch February 22, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants