-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow bridleways with bicycle=yes for bike profiles #1172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot for your prompt fix!
See my comment on the usage of KEY_BRIDLEWAY
.
Cheers,
Andrzej
...a/org/heigit/ors/routing/graphhopper/extensions/flagencoders/bike/CommonBikeFlagEncoder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks again!
Did you have a chance to actually test whether the routing after the change behaves as expected? I don't think there are any bridleways in the HD test graph, however, there are some ways tagged with highway=bridleway
and bicycle=yes
around Lorsch/Heppenheim. You might want to use these as a test case.
Cheers,
Andrzej
I have added a unit test that verifies correct assignment of access value, and I've tested on a modified Heidelberg graph, I think it's safe to assume it works the intended way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot @takb for the fix!
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes #1167 .
Information about the changes
allow bridleways with bicycle=yes for bike profiles