Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow bridleways with bicycle=yes for bike profiles #1172

Merged
merged 6 commits into from
Jun 20, 2022

Conversation

takb
Copy link
Contributor

@takb takb commented May 25, 2022

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Fixes #1167 .

Information about the changes

  • Key functionality added:
    allow bridleways with bicycle=yes for bike profiles

Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot for your prompt fix!

See my comment on the usage of KEY_BRIDLEWAY.

Cheers,
Andrzej

@takb takb requested a review from aoles May 25, 2022 11:32
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

Did you have a chance to actually test whether the routing after the change behaves as expected? I don't think there are any bridleways in the HD test graph, however, there are some ways tagged with highway=bridleway and bicycle=yes around Lorsch/Heppenheim. You might want to use these as a test case.

Cheers,
Andrzej

@takb
Copy link
Contributor Author

takb commented Jun 15, 2022

I have added a unit test that verifies correct assignment of access value, and I've tested on a modified Heidelberg graph, I think it's safe to assume it works the intended way.

@takb takb requested a review from aoles June 15, 2022 13:04
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @takb for the fix!

@takb takb merged commit e71bfbe into master Jun 20, 2022
@takb takb deleted the bugfix-#1167-bike-bridleway branch June 20, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bridleway with bicycle=yes not used for bike routing
2 participants