-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 4.0 upgrade #1217
Merged
Merged
Gh 4.0 upgrade #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GraphHopper profile needs to be selected by name. Therefore, we have to generate the right profile name when setting up the requests.
The LocationIndex.query was changed from using a node-based to using an edge-based approach. Nodes therefore have to be inferred from the edges.
The GraphHopper profile needs to be selected by name. Therefore, we have to generate the right profile name when setting up the requests.
Adapt LocationIndex query in centrality to GH4.0
…eparationHandlerTest
The MaximumSpeedCalculator was initialized in a method removed from class GraphHopper. Now, the SpeedCalculator is initialized in class Router.
Rphast gh update
Gh update dijkstramatrix
This facilitates building of CH graphs with default HGV vehicle type set.
The supposedly unused flag `hgvDestination` has been removed in cf5717b. However, as it is not entirely clear what the intended functionality behind it was, it probably requires a proper assessment before it can be safely removed.
For backwards compatibility reasons some OSM barriers such as "lift_gate" should remain blocked for certain vehicles unless explicitly tagged as passable.
The current glibc version is not properly finding musl dependencies.
Edge weights for core edges can be altered at query time. As such they should be obtained directly from the corresponding weighting.
Currently multiple jts geometries from locationtech and vividsolutions are used. In some scenarios the load order is different and gh cannot handle old vividsolutions jts anymore, so it fails. This fix forces the jackson-datatype-jts library from graphhopper back into the class context with jackson-databind excluded.
find and replace com.vividsolutions with org.locationtech removed the dependency: - com.vividsolutions.jts - org.geotools.gt-api - com.bedatadrive.jackson-datatype-jts dumped up the version of geotools to 27.2 added the dependecy: - org.geotools.gt-metadata
This was only done in GHs FlexSolver class, not in our ORSRouter.CoreSolver class. This lead to points on avoidables (e.g. highways) getting snapped to said avoidable if avoided.
…calc Re-introduce the actual distance calculation for ferry ways
sfendrich
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending results from benchmarking this can be merged soon