Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 4.0 upgrade #1217

Merged
merged 362 commits into from
Mar 3, 2023
Merged

Gh 4.0 upgrade #1217

merged 362 commits into from
Mar 3, 2023

Conversation

takb
Copy link
Contributor

@takb takb commented Sep 27, 2022

Pending results from benchmarking this can be merged soon

Hendrik Leuschner and others added 30 commits February 3, 2022 13:10
The GraphHopper profile needs to be selected by name. Therefore,
we have to generate the right profile name when setting up the
requests.
The LocationIndex.query was changed from using a node-based to using an edge-based approach.
Nodes therefore have to be inferred from the edges.
The GraphHopper profile needs to be selected by name. Therefore,
we have to generate the right profile name when setting up the
requests.
Adapt LocationIndex query in centrality to GH4.0
The MaximumSpeedCalculator was initialized in a method removed
from class GraphHopper. Now, the SpeedCalculator is initialized
in class Router.
takb and others added 17 commits February 21, 2023 11:57
This facilitates building of CH graphs with default HGV vehicle type set.
The supposedly unused flag `hgvDestination` has been removed in cf5717b. However, as it is not entirely clear what the intended functionality behind it was, it probably requires a proper assessment before it can be safely removed.
For backwards compatibility reasons some OSM barriers such as "lift_gate" should remain blocked for certain vehicles unless explicitly tagged as passable.
The current glibc version is not properly finding musl dependencies.
Edge weights for core edges can be altered at query time. As such they should be obtained directly from the corresponding weighting.
Currently multiple jts geometries from locationtech and vividsolutions are used. In some scenarios the load order is different and gh cannot handle old vividsolutions jts anymore, so it fails. This fix forces the jackson-datatype-jts library from graphhopper back into the class context with jackson-databind excluded.
find and replace com.vividsolutions with org.locationtech
removed the dependency:
- com.vividsolutions.jts
- org.geotools.gt-api
- com.bedatadrive.jackson-datatype-jts
dumped up the version of geotools to 27.2
added the dependecy:
- org.geotools.gt-metadata
This was only done in GHs FlexSolver class, not in our ORSRouter.CoreSolver class.
This lead to points on avoidables (e.g. highways) getting snapped to said avoidable if avoided.
@MichaelsJP MichaelsJP added this to the Release 7.0.0 milestone Feb 28, 2023
Copy link
Contributor

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MichaelsJP MichaelsJP merged commit b428001 into master Mar 3, 2023
@MichaelsJP MichaelsJP deleted the gh-4.0-upgrade branch March 3, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants