optional parameter force_turn_costs

[takb]

Pull Request Checklist

• 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
  have been resolved.
• 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
  [Unreleased] heading.
• 3. I have documented my code using JDocs tags.
• 4. I have removed unnecessary commented out code, imports and System.out.println statements.
• 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
• 6. I have created API tests for any new functionality exposed to the API.
• 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
  along with a short description of what it is for, and documented this in the Pull Request (below).
• 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
• 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
• 10. For new features or changes involving building of graphs, I have tested on a larger dataset
  (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
• 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
  importer etc.), I have generated longer distance routes for the affected profiles with different options
  (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
  points generated from the current live ORS.
  If there are differences then the reasoning for these MUST be documented in the pull request.
• 12. I have written in the Pull Request information about the changes made including their intended usage
  and why the change was needed.
• 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Fixes #1220 .

Information about the changes

• Key functionality added:
  optional profile parameter force_turn_costs
  If true, algorithm selection defaults to FLEX_PREPROCESSED mode instead of FLEX_STATIC.

[sfendrich]

LGTM

[aoles]

Thanks a lot @takb !

I encourage you to re-consider whether the new parameter force_turn_cost really belongs under encoder_options. I would argue that the parameters to encoder_options influence the base graph storage at build time, whereas forcing turn costs is a strictly run-time parameter. Therefore, my suggestion would be to move the parameter one level up to the general profile parameters. Does that make sense to you? Cheers!

[takb]

You're absolutely right @aoles , moved the parameter.

[aoles]

Thanks @takb , please see my inline comments. Cheers!

[aoles]

Thanks again @takb !