refactor: configuration improvements phase 1 #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The usage of the static MatrixServiceSettings has been moved towards the API-boundary as a preparation to the new configuration system. As soon as the new config system is in place at the APi-side, the remaining static usages of MAtrixServiceSettings can be replaced.
The following matrix config parameters of the new configuration system have been integrated: maximum_visited_nodes, maximum_search_radius.
The new config system should replace all usages of the static *ServiceSettings classes. This commit reduces the number of usages of MatrixServiceSettings. The remaining usages require larger refactorings ans shall be addressed separately.
This commit removes the usage of the static MatrixServiceSettings from AbstractManyToManyMatrixAlgorithm in favor of the new configuration system. Unfortunately, the current structure of the matrix algorithms forced this commit to pass around the boolean "hasInfiniteUTurnCosts" through several classes. This should be cleaned up together with the matrix algorithms in a later commit.
The static *ServiceSettings classes are to be removed in favor of the new configuration system. This commit reduces the number of usages of RoutingServiceSettings.
…uting.attribution
takb
changed the title
MichaelsJP
changed the title
|
Imo “refactor” fits it best right now. When the new config split will be available as the main entrance to the user, I'd say we call that switch "feature". |
MichaelsJP
reviewed
Jul 7, 2023
ors-api/src/main/java/org/heigit/ors/api/servlet/listeners/ORSInitContextListener.java
Show resolved
Hide resolved
MichaelsJP
approved these changes
Jul 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information about the changes
This is a WIP merge, code compiles and runs and all tests succeed, but the new configuration method is not completely functional, especially the profiles configuation part.