Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove elevation smoother #1511

Merged
merged 10 commits into from
Aug 8, 2023
Merged

fix: remove elevation smoother #1511

merged 10 commits into from
Aug 8, 2023

Conversation

sfendrich
Copy link
Contributor

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Fixes #625, #770, #1470 .

Information about the changes

  • Key functionality added: removed obsolete ElevationSmoother
  • Reason for change: buggy; superseded by GH's internal elevation smoothing

@MichaelsJP MichaelsJP changed the title Fix/remove elevation smoother fix: remove elevation smoother Aug 4, 2023
@github-actions github-actions bot added the fix label Aug 4, 2023
@jhaeu jhaeu requested a review from MichaelsJP August 7, 2023 08:07
@github-actions github-actions bot removed the fix label Aug 7, 2023
@jhaeu jhaeu requested review from koebi, aoles and takb August 7, 2023 08:07
@github-actions github-actions bot added fix and removed fix labels Aug 7, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@MichaelsJP MichaelsJP self-requested a review August 8, 2023 07:49
@github-actions github-actions bot added fix and removed fix labels Aug 8, 2023
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change in the changelog

@MichaelsJP MichaelsJP removed request for koebi, aoles and takb August 8, 2023 07:50
@MichaelsJP MichaelsJP force-pushed the fix/remove-elevation-smoother branch from e3b68b1 to e29ba1c Compare August 8, 2023 08:03
@jhaeu jhaeu enabled auto-merge (squash) August 8, 2023 08:14
@jhaeu jhaeu merged commit 21aafa2 into master Aug 8, 2023
@jhaeu jhaeu deleted the fix/remove-elevation-smoother branch August 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

different elevation for the exact same point
4 participants