Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fastisochrones): Fix the max visited nodes bug for fast-isochrones #1538

Merged

Conversation

MichaelsJP
Copy link
Member

The new max visited nodes check for the matrix api introduced an error which works well when querying via the api. When the fast-algorithm quries the matrix code, it needs a true or false feedback and not an error to abort a search. That logic works now again.

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@MichaelsJP MichaelsJP self-assigned this Sep 6, 2023
@github-actions github-actions bot added the fix label Sep 6, 2023
@MichaelsJP MichaelsJP changed the title fix(fastisochrones): Fix the max visited nodes break for fast-isochrones fix(fastisochrones): Fix the max visited nodes bug for fast-isochrones Sep 6, 2023
The new max visited nodes check for the matrix api introduced an error which works well when querying via the api. When the fast-algorithm quries the matrix code, it needs a true or false feedback and not an error to abort a search. That logic works now again.
@github-actions github-actions bot added fix and removed fix labels Sep 6, 2023
@MichaelsJP MichaelsJP force-pushed the fix/fast-isochrones-max-visited-nodes-fix branch from 074ffc9 to 2e3f2e2 Compare September 6, 2023 16:41
@MichaelsJP MichaelsJP enabled auto-merge September 6, 2023 16:44
@github-actions github-actions bot added fix and removed fix labels Sep 6, 2023
Copy link
Contributor

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is only a part of the story. Two things to be considered:

  1. on my machine this version still takes 3x as long as 6.8 (compared to 5x before this fix)
  2. it is currently unclear, whether stopping search on maxVisitedNodes is the right behavior for computing border node distances of a cell. In particular it seems this happens more often than in 6.8.

@MichaelsJP MichaelsJP merged commit 24689d8 into releases/v7.2.x Sep 7, 2023
@MichaelsJP MichaelsJP deleted the fix/fast-isochrones-max-visited-nodes-fix branch September 7, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants