Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fastisochrones): use correct edge filter fast-isochrones snapping #1572

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

MichaelsJP
Copy link
Member

(cherry picked from commit f4d9909)

Pull Request Checklist

  • 1. I have rebased the latest version of the master branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes # .

Information about the changes

  • Key functionality added:
  • Reason for change:

Examples and reasons for differences between live ORS routes, and those generated from this pull request

Required changes to ors config (if applicable)

@MichaelsJP MichaelsJP marked this pull request as draft October 18, 2023 14:38
@github-actions github-actions bot added the fix label Oct 18, 2023
@MichaelsJP MichaelsJP force-pushed the fix/fast-isochrones-snapping-bug branch from a8f2603 to 5b94591 Compare October 18, 2023 14:39
@MichaelsJP MichaelsJP force-pushed the fix/fast-isochrones-snapping-bug branch from 5b94591 to 60e3e0a Compare October 18, 2023 14:43
@MichaelsJP MichaelsJP marked this pull request as ready for review October 18, 2023 14:44
@github-actions github-actions bot added fix and removed fix labels Oct 18, 2023
@MichaelsJP
Copy link
Member Author

MichaelsJP commented Oct 18, 2023

This is a direct cherry-pick and should be reviewed carefully. Refactoring (making it nicer) welcome.

@MichaelsJP MichaelsJP requested review from aoles and sfendrich October 18, 2023 14:44
@github-actions github-actions bot added fix and removed fix labels Oct 18, 2023
@MichaelsJP MichaelsJP enabled auto-merge October 18, 2023 14:45
Copy link
Member

@aoles aoles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as the first iteration 🚀

I agree some refactoring would be nice. In fact, I already have some ideas how to tidy up the classes for the sake of DRYness, but I would prefer to do it in a separate PR purely focused on refactoring.

@MichaelsJP MichaelsJP merged commit 35a6d2e into master Oct 19, 2023
23 checks passed
@MichaelsJP MichaelsJP deleted the fix/fast-isochrones-snapping-bug branch October 19, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

2 participants