Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release artifacts #1669

Merged
merged 5 commits into from
Feb 13, 2024
Merged

ci: release artifacts #1669

merged 5 commits into from
Feb 13, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Jan 31, 2024 •
edited
Loading

Information about the changes

  • default build option is JAR
  • added workflow triggered on release to build and attach JAR and WAR artifacts

Fixes #1665 .
Fixes #1667 .

@takb takb requested a review from MichaelsJP January 31, 2024 16:58
@github-actions github-actions bot added the ci label Jan 31, 2024
@takb takb enabled auto-merge January 31, 2024 16:58
@github-actions github-actions bot added ci and removed ci labels Jan 31, 2024
@takb takb force-pushed the ci/release-artifacts branch from 3c53052 to 067d5b8 Compare February 1, 2024 09:07
@github-actions github-actions bot added ci and removed ci labels Feb 2, 2024
koebi
koebi requested changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@koebi koebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nitpick.

.github/workflows/vulnerability-scanning.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added ci and removed ci labels Feb 13, 2024
@TheGreatRefrigerator
Copy link
Contributor

Vulnerabilitiy and docker issues will be handled separately.

@github-actions github-actions bot added ci and removed ci labels Feb 13, 2024
@TheGreatRefrigerator TheGreatRefrigerator merged commit d025605 into main Feb 13, 2024
8 of 12 checks passed
@TheGreatRefrigerator TheGreatRefrigerator deleted the ci/release-artifacts branch February 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebi koebi koebi approved these changes

@MichaelsJP MichaelsJP Awaiting requested review from MichaelsJP

@TheGreatRefrigerator TheGreatRefrigerator Awaiting requested review from TheGreatRefrigerator

Assignees
No one assigned
Labels
ci
Projects
No open projects
ors general
Status: Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust the test workflows for the jar deployment Upload war and jar artifacts to the releases
3 participants
@takb @TheGreatRefrigerator @koebi