Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: env params logging #1676

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: env params logging #1676

merged 1 commit into from
Feb 5, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Feb 2, 2024

Information about the changes

  • Reason for change:
    Minor fix to runtime config params & logging.

@takb takb requested a review from jhaeu February 2, 2024 12:51
@github-actions github-actions bot added fix and removed fix labels Feb 2, 2024
@github-actions github-actions bot added the fix label Feb 2, 2024
@takb takb enabled auto-merge February 2, 2024 15:54
@takb takb requested a review from sfendrich February 5, 2024 08:09
@github-actions github-actions bot added fix and removed fix labels Feb 5, 2024
sfendrich
sfendrich approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@sfendrich sfendrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@takb takb merged commit 01f732f into main Feb 5, 2024
22 checks passed
@takb takb deleted the fix/env-param-logging branch February 5, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfendrich sfendrich sfendrich approved these changes

@jhaeu jhaeu Awaiting requested review from jhaeu

Assignees
No one assigned
Labels
fix
Projects
No open projects
ors general
Status: Awaiting release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takb @sfendrich