fix(logging): Enhance logging for here matching progress #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelsJP
force-pushed
the
fix/progress-bar
branch
15 times, most recently
from
08ce875 to
e30af62
Compare
Implement a more declarative usage of the logging facility, since it's the recommended way to use this package. It includes better readability, straightforward log delegation to the system logger, shared logging facility, sensible update interval instead of the modulo check and the removal of a random memory leak from the for-with implementation by using the builder class. It should be termination safe, but somehow isn't always. The progressbar is now configured to use the ConsoleProgressBarConsumer with a defined printStream. The printStream allows overwriting of prior lines with a carriage return and an uncomplicated configuration of the log level.
Graphhopper throws an IllegalArgumentException when the matching fails. This is to be expected when matching here traffic on osm files without the corresponding edges. The exception is caught and logged as a trace to avoid cluttering the log with expected exceptions.
MichaelsJP
force-pushed
the
fix/progress-bar
branch
2 times, most recently
from
0bc27ab to
8d0d7e3
Compare
The class is designed to capture the current console pattern and output the progress bar in one line instead of multiple by keeping the style. Some very trivial tests are added to the custom class to ensure correct initialization. Once the progress is done, the bar automatically gets deleted from the log output.
This package is needed by something in the RoutingProfileLoader
MichaelsJP
force-pushed
the
fix/progress-bar
branch
from
8d0d7e3 to
c31d476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a more declarative usage of the logging facility, since it's the recommended way to use this package. It includes better readability, straightforward log delegation to the system logger, shared logging facility, sensible update interval instead of the modulo check and the removal of a random memory leak from the for-with implementation by using the builder class. It should be termination safe, but somehow isn't always.
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)