-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rewrite docu for docker setup #1746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intermediate review. Not yet through.
We should also adapt the installation part in the Readme.md. |
0cec499
to
13670b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but someone else from the team should definitely look over it as well!
One thing, please add a changelog entry still before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point me to the workflow that takes care of the release assets?
Also, we should add an overview of the existing official docker images and link it from the README.
@koebi Here you go
This releases the docker image as well as uploading release artifacts. This workflow takes care of setting the additional tags: |
a5c1288
to
613bdd0
Compare
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
Co-authored-by: Jakob Schnell <Jakob.Schnell@heigit.org>
52e1814
to
6eb0706
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor notes, otherwise it looks good to me :)
Quality Gate passedIssues Measures |
Pull Request Checklist
have been resolved.
[Unreleased] heading.
along with a short description of what it is for, and documented this in the Pull Request (below).
(at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
importer etc.), I have generated longer distance routes for the affected profiles with different options
(avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
points generated from the current live ORS.
If there are differences then the reasoning for these MUST be documented in the pull request.
and why the change was needed.
Fixes # .
Information about the changes
Examples and reasons for differences between live ORS routes, and those generated from this pull request
Required changes to ors config (if applicable)