Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependencies #1827

Merged
merged 3 commits into from
Jul 30, 2024
Merged

build: update dependencies #1827

merged 3 commits into from
Jul 30, 2024

Conversation

takb
Copy link
Contributor

@takb takb commented Jul 29, 2024

Pull Request Checklist

  • 1. I have [rebased][rebase] the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the [ors config documentation][config]
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground [renders correctly][api].

Fixes #1814 .

Information about the changes

  • Reason for change:
    Updated dependencies: spring, swagger, geotools etc.

@github-actions github-actions bot added the build label Jul 29, 2024
@github-actions github-actions bot added build and removed build labels Jul 29, 2024
@takb takb marked this pull request as ready for review July 29, 2024 14:43
@takb takb requested a review from MichaelsJP July 29, 2024 14:43
@github-actions github-actions bot added build and removed build labels Jul 29, 2024
Copy link
Member

@MichaelsJP MichaelsJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelsJP MichaelsJP force-pushed the build/update-dependencies branch from af5c543 to e7893f3 Compare July 30, 2024 07:50
@MichaelsJP MichaelsJP enabled auto-merge July 30, 2024 07:50
@MichaelsJP MichaelsJP disabled auto-merge July 30, 2024 07:50
@MichaelsJP MichaelsJP enabled auto-merge July 30, 2024 07:51
Copy link

@MichaelsJP MichaelsJP merged commit 3c0d2b3 into main Jul 30, 2024
43 checks passed
@MichaelsJP MichaelsJP deleted the build/update-dependencies branch July 30, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Awaiting release
Development

Successfully merging this pull request may close these issues.

CVE-2024-34750
2 participants