Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access to roads where transporting hazardous materials is forbidden #1853

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

aoles
Copy link
Member

@aoles aoles commented Sep 30, 2024

Pull Request Checklist

  • 1. I have rebased the latest version of the main branch into my feature branch and all conflicts
    have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the
    [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/classes and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the ors-config.json file, I have added these to the ors config documentation
    along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset
    (at least Germany), and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the
    importer etc.), I have generated longer distance routes for the affected profiles with different options
    (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end
    points generated from the current live ORS.
    If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage
    and why the change was needed.
  • 13. For changes touching the API documentation, I have tested that the API playground renders correctly.

Fixes #1813

Information about the changes

Fixes a phenomenon, where access to ways tagged with both hazmat=no and maxheight was blocked regardless of the corresponding query flag.

The reason for this bizarre behavior has been that the method which retrieves vehicle type value from the storage has been reading two consecutive bytes into a buffer mis-interpreting the second byte as a special type of destination flag. The flag, however, was removed from the storage a while ago, resulting in the value being set to the first byte of the numerical maxheight restriction.

@github-actions github-actions bot added the fix label Sep 30, 2024
@github-actions github-actions bot added fix and removed fix labels Sep 30, 2024
Copy link

@aoles aoles enabled auto-merge September 30, 2024 14:18
@aoles aoles requested review from takb and removed request for TheGreatRefrigerator October 1, 2024 09:13
@github-actions github-actions bot added fix and removed fix labels Oct 1, 2024
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aoles aoles merged commit 3f2e4fc into main Oct 1, 2024
45 checks passed
@aoles aoles deleted the fix/hgv_hazmat branch October 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hgv route avoids 'hazmat:no' ways
2 participants