Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed depricated services from web.xml #188

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

rabidllama
Copy link
Contributor

Pull Request Checklist

  • 1. I have merged the latest version of the development branch into my feature branch and all conflicts have been resolved
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading
    - [ ] 3. I have documented my code using JDocs tags
    - [ ] 4. I have removed unecessary commented out code, imports and System.out.println statements
    - [ ] 5. I have written JUnit tests for any new methods/classes and ensured that they pass
    - [ ] 6. I have created API tests for any new functionality exposed to the API
    - [ ] 7. If changes/additions are made to the app.config file, I have added these to the app.config.sample file along with a short description of what it is for, and documented this in the Pull Request (below)
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue)
    - [ ] 10. For new features involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors)
  • 11. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #186 .

Information about the changes

  • Key functionality added: Removed depricated services (accessibility and locations) from web.xml
  • Reason for change: As these classes had been removed from the code, warning/error messages were being shown at build time

Required changes to app.config (if applicable)

@rabidllama rabidllama added the bug 🐞 Erroneous behavior of the backend label Jun 6, 2018
@rabidllama rabidllama added this to the 4.6 milestone Jun 6, 2018
@rabidllama rabidllama requested a review from TimMcCauley June 6, 2018 09:10
Copy link
Contributor

@TimMcCauley TimMcCauley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK NICE RABID

@TimMcCauley TimMcCauley merged commit 8ef4536 into development Jun 6, 2018
@TimMcCauley TimMcCauley deleted the fix_remove_services_from_web_xml branch June 6, 2018 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Erroneous behavior of the backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants