Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter to app.config and check for maximum allowed round trip distance #661

Merged
merged 3 commits into from
Jan 24, 2020

Conversation

rabidllama
Copy link
Contributor

Pull Request Checklist

  • 1. I have rebased the latest version of the development branch into my feature branch and all conflicts have been resolved.
  • 2. I have added information about the change/addition to functionality to the CHANGELOG.md file under the [Unreleased] heading.
  • 3. I have documented my code using JDocs tags.
  • 4. I have removed unnecessary commented out code, imports and System.out.println statements.
  • 5. I have written JUnit tests for any new methods/cl asses and ensured that they pass.
  • 6. I have created API tests for any new functionality exposed to the API.
  • 7. If changes/additions are made to the app.config file, I have added these to the app.config wiki page on github along with a short description of what it is for, and documented this in the Pull Request (below).
  • 8. I have built graphs with my code of the Heidelberg.osm.gz file and run the api-tests with all test passing
  • 9. I have referenced the Issue Number in the Pull Request (if the changes were from an issue).
  • 10. For new features or changes involving building of graphs, I have tested on a larger dataset (at least Germany) and the graphs build without problems (i.e. no out-of-memory errors).
  • 11. For new features or changes involving the graphbuilding process (i.e. changing encoders, updating the importer etc.), I have generated longer distance routes for the affected profiles with different options (avoid features, max weight etc.) and compared these with the routes of the same parameters and start/end points generated from the current live ORS. If there are differences then the reasoning for these MUST be documented in the pull request.
  • 12. I have written in the Pull Request information about the changes made including their intended usage and why the change was needed.

Fixes #658 .

Information about the changes

  • Key functionality added: Added app.config parameter for maximum distance of round trip routes and added code to check against this and throw an exception if the value provided is larger
  • Reason for change: The current round trip algorithm in GraphHopper does not use optimisations, and so longer routes would be much slower.

Examples and reasons for differences between live ORS routes and those generated from this pull request

Required changes to app.config (if applicable)

  • Added parameter "maximum_distance_round_trip_routes": xxx,

@rabidllama rabidllama requested review from sfendrich and takb January 24, 2020 08:45
Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the value also to docker/conf/app.config.sample

Copy link
Contributor

@takb takb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@takb takb merged commit a776238 into development Jan 24, 2020
@rabidllama rabidllama deleted the fix-#658/add_length_restriction_to_roundtrip branch February 7, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants