Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagTranslator creates a new PreparedStatment for every translation. #221

Closed
rtroilo opened this issue Apr 2, 2020 · 0 comments
Closed

TagTranslator creates a new PreparedStatment for every translation. #221

rtroilo opened this issue Apr 2, 2020 · 0 comments
Labels
code quality Related to our standards for 'good' code performance Performance optimizations, bottlenecks of the current pipeline, etc.

Comments

@rtroilo
Copy link
Member

rtroilo commented Apr 2, 2020

in
getOSHDBTagOf(OSMTag tag)
and
OSMTag getOSMTagOf(OSHDBTag tag)

every time a new PreparedStatment will be created instead of reusing them as there are intended.
@tyrasd tyrasd added addressing Someone is addressing this issue. You should contact them, before making any contributions. code quality Related to our standards for 'good' code performance Performance optimizations, bottlenecks of the current pipeline, etc. labels Apr 4, 2020
@tyrasd tyrasd changed the title TagTranlater creates a new PreparedStatment for every translation. TagTranslator creates a new PreparedStatment for every translation. Apr 4, 2020
tyrasd added a commit that referenced this issue Apr 4, 2020
@tyrasd
improve sql querying of tags, fixes #221
66d0b9c 
* prepare statements in constructor and reuse them
* make the class autoclosable
* close resultsets after they are used
* fix checkstyle warnings
@tyrasd tyrasd closed this as completed in a6e1852 Apr 6, 2020
@tyrasd tyrasd removed the addressing Someone is addressing this issue. You should contact them, before making any contributions. label Apr 6, 2020
tyrasd added a commit that referenced this issue Apr 6, 2020
@tyrasd
Revert "improve sql querying of tags, fixes #221"
2573385 
This reverts commit a6e1852.
@tyrasd tyrasd mentioned this issue Apr 6, 2020
Merged
@tyrasd tyrasd reopened this Apr 6, 2020
@tyrasd tyrasd added the addressing Someone is addressing this issue. You should contact them, before making any contributions. label Apr 6, 2020
@tyrasd tyrasd closed this as completed in 3a21bbd Apr 6, 2020
@tyrasd tyrasd reopened this Apr 6, 2020
@tyrasd tyrasd closed this as completed in 2e28443 Apr 7, 2020
@tyrasd tyrasd removed the addressing Someone is addressing this issue. You should contact them, before making any contributions. label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Related to our standards for 'good' code performance Performance optimizations, bottlenecks of the current pipeline, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyrasd @rtroilo