Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix checkstyle warnings in oshdb-util #275

Merged
merged 9 commits into from
Nov 5, 2020
Merged

fix checkstyle warnings in oshdb-util #275

merged 9 commits into from
Nov 5, 2020

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Oct 30, 2020 •
edited
Loading

🚧

Changes proposed in this pull request:

Type of change

  • Warnings fix (non-breaking change which fixes an issue)

Description

  • Fix CheckStyle

Corresponding issue

Supports #90

Checklist

@joker234 joker234 added the code quality Related to our standards for 'good' code label Oct 30, 2020
@joker234 joker234 added this to the release 0.6.0 milestone Oct 30, 2020
@joker234 joker234 force-pushed the fix-checkstyle-util branch from 8219c42 to c392b60 Compare October 30, 2020 16:47
@joker234 joker234 changed the title 🚧 fix non-javadoc checkstyle warnings in oshdb-util 🚧 fix checkstyle warnings in oshdb-util Oct 30, 2020
@joker234 joker234 linked an issue Oct 30, 2020 that may be closed by this pull request
Solve Checkstyle Warnings #90
Closed
5 tasks
@tyrasd tyrasd changed the base branch from master to fix-issue-259-timestamp-formats November 2, 2020 12:53
@tyrasd tyrasd changed the base branch from fix-issue-259-timestamp-formats to master November 2, 2020 12:53
@joker234 joker234 force-pushed the fix-checkstyle-util branch 2 times, most recently from caeefa3 to 3361fbe Compare November 4, 2020 10:43
@joker234 joker234 force-pushed the fix-checkstyle-util branch from 6b2973a to b1548de Compare November 4, 2020 19:27
@joker234 joker234 changed the title 🚧 fix checkstyle warnings in oshdb-util fix checkstyle warnings in oshdb-util Nov 4, 2020
@joker234 joker234 requested review from rtroilo and tyrasd November 4, 2020 19:27
@joker234 joker234 added the waiting for review This pull request needs a code review label Nov 4, 2020
tyrasd
tyrasd reviewed Nov 5, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
@joker234 joker234 requested a review from tyrasd November 5, 2020 10:15
@joker234
Copy link
Member Author

joker234 commented Nov 5, 2020

According to https://jenkins.ohsome.org/job/oshdb/view/change-requests/job/PR-275/13/checkstyle/#moduleNameContent all checkstyle warnings are now solved.

@joker234 joker234 force-pushed the fix-checkstyle-util branch from af07cc0 to 5e321d2 Compare November 5, 2020 10:57
@joker234 joker234 merged commit 1da5dfa into master Nov 5, 2020
@joker234 joker234 deleted the fix-checkstyle-util branch November 5, 2020 11:49
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Dec 3, 2020
@joker234 joker234 mentioned this pull request Dec 7, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

@rtroilo rtroilo Awaiting requested review from rtroilo

Assignees
No one assigned
Labels
code quality Related to our standards for 'good' code
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

Solve Checkstyle Warnings
2 participants
@joker234 @tyrasd