Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace unnecessary Map with a List #352

Merged
merged 3 commits into from
Feb 16, 2021
Merged

replace unnecessary Map with a List #352

merged 3 commits into from
Feb 16, 2021

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Feb 11, 2021

implements suggestion from @rtroilo in #332 (comment)

Description

Replaces a not necessary usage of a (sorted) Map with a simple List. Should lead to slightly improved performance in some queries and reduced memory consumption.

Checklist

@tyrasd tyrasd added the performance Performance optimizations, bottlenecks of the current pipeline, etc. label Feb 11, 2021
@tyrasd tyrasd added this to the release 0.7.0 milestone Feb 11, 2021
@tyrasd tyrasd requested a review from rtroilo February 11, 2021 15:19
@tyrasd
Copy link
Member Author

tyrasd commented Feb 11, 2021

4c3b709 is actually unrelated (was missing in #332), but I thought it's ok to sneak these changes in here 😇

Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@tyrasd tyrasd merged commit 7454255 into master Feb 16, 2021
@tyrasd tyrasd deleted the refactor-oshutils branch February 16, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance optimizations, bottlenecks of the current pipeline, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants