Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improvements to area processing #52

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aoles
Copy link
Member

@aoles aoles commented Jun 21, 2024

Summary of changes

  • Pre-check against bounding boxes first before performing a full geometrical check
    • 2x speedup of area mapping (132 s vs. 281 s)
    • 12% speedup of second pass (520 s vs. 593 s)
  • Reduce grid size from 1.0 to 0.5 degree
    • ca. 2x speedup of 2nd pass (250 vs. 520 s) at a cost of over 3x longer area mapping (448 s vs 132 s)

TODOs

  • parametrized instead of hard-coded grid size
  • for area mapping consider only the sub-grid confined to area's bounding box instead of performing a full grid scan

@aoles aoles marked this pull request as draft June 23, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant