Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: restyle consent action on /digitize before uploading sketchmaps #532

Open
mcauer opened this issue Feb 21, 2025 · 2 comments · May be fixed by #535
Open

ui: restyle consent action on /digitize before uploading sketchmaps #532

mcauer opened this issue Feb 21, 2025 · 2 comments · May be fixed by #535
Assignees
@mcauer @rtroilo
Labels
component:website

Comments

@mcauer
Copy link
Member

mcauer commented Feb 21, 2025

Aim: Simplifiy logic and interaction flow when uploading maps.
Related to #496
Other than in #496 this avoids further steps for the user but still forces an active and informed decision for the consent.
@mcauer
Copy link
Member Author

mcauer commented Feb 21, 2025 •
edited
Loading

These translations have been removed:

  • _(' Files are stored for processing until the results are generated.')
  • _('Enable us to keep the uploaded files beyond processing to further improve this service.')
  • _('Upload')

These new ones have been added:

  • _('Help us to improve the Sketch Map Tool for everyone')
  • _('To train and improve the sketch detection algorithms,
    we do need your real use-case data and would like to ask for your permission
    to keep the uploaded files after processing.')
  • _('Agree & Upload')
  • _('OR')
  • _('Reject & Upload')
  • _('If you agree, we would keep your data internally to use it as training and
    test data to improve the Sketch Map Tool.')
  • _("If you don't agree, your files are ONLY stored for processing for a short time
    until your results are generated.")
  • _('Read more info on')

mcauer added a commit that referenced this issue Feb 21, 2025
@mcauer
refactor: restyle-consent-action
e0c0955 
#532

Refs: #532
@mcauer
Copy link
Member Author

mcauer commented Feb 21, 2025

Image

mcauer added a commit that referenced this issue Feb 22, 2025
@mcauer
refactor: replace consent checkbox by a hidden form field
6bfdc32 
Values of the hidden form field depend on the selected upload button and will always be sent.
Values will be "True" or "False"

Needed new logic in routes.py to read out the consent value!

#532

Refs: #532
@matthiasschaub matthiasschaub linked a pull request Feb 22, 2025 that will close this issue
532 UI restyle consent action on digitize before uploading sketchmaps #535
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcauer mcauer

@rtroilo rtroilo

Labels
component:website
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

532 UI restyle consent action on digitize before uploading sketchmaps GIScience/sketch-map-tool
2 participants
@mcauer @rtroilo