-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close #207: Limit the max. number of uploaded files #248
Merged
mhhd2020
merged 10 commits into
main
from
207-restrict-number-of-images-during-upload-handling
Jul 5, 2023
Merged
Close #207: Limit the max. number of uploaded files #248
mhhd2020
merged 10 commits into
main
from
207-restrict-number-of-images-during-upload-handling
Jul 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it possible to write a test case for this? |
Yes and Done |
matthiasschaub
previously requested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some suggestions regarding tests, otherwise fine :)
mhhd2020
force-pushed
the
207-restrict-number-of-images-during-upload-handling
branch
from
July 3, 2023 16:20
849919f
to
b078b0a
Compare
matthiasschaub
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we once defined 80 uploads per user as upper boundary of what should be sufficient for the vast majority of uses, I set a value slightly above that (100). In case one needs more, one can of course always split up the uploads and later merge the files in a GIS. As this value is, therefore, theoretically reasoned and should be valid for all instances of the tool, it is not included in the config. However, if you deem it sensible to set this value in the config, I can change it accordingly.